search

SocialiteProviders / Providers

A Collection of Providers for Laravel Socialite
https://socialiteproviders.com
MIT License
488 stars 436 forks source link

Merge Microsoft and Azure provider #1138

Open buddhaCode opened 5 months ago

buddhaCode commented 5 months ago

Hi folks, Hi @atymic, I was wondering what the difference between these two providers are. As far as I found out, I can use both to authenticate against an Azure AD. Is that right?

Best, Arne

atymic commented 5 months ago

That's a good question. Looking at the code, it seems you are correct. I think we should deprecate one of them, probably the azure one. The azure one seems to support proxies, but apart from that the microsoft provider seems to have more features.

atymic commented 5 months ago

I would probably use the Microsoft one, PRSs welcome to add the proxy feature to the Microsoft one, and test to make sure it works as expected :)

buddhaCode commented 5 months ago

Okay thanks for your reply. Indeed, we migrated from the Azure to the Microsoft provider.

We need to access some custom attribute on the user data. But after an update of the Azure provider this wasn't possible anymore. But with the Microsoft provider it's still possible to retrieve extra custom attributes.

atymic commented 1 week ago

I've brought across proxy support in https://github.com/SocialiteProviders/Providers/pull/1226 Is there anything missing from the azure provider now?