search

SocialiteProviders / Providers

A Collection of Providers for Laravel Socialite
https://socialiteproviders.com
MIT License
487 stars 435 forks source link

Can we add the "department" attribute to the azure provider's mapped fields? #1223

Closed PaddingtonBrown closed 4 days ago

PaddingtonBrown commented 1 week ago

Relates to https://github.com/SocialiteProviders/Providers/issues/745

PaddingtonBrown commented 1 week ago

In azure provider https://github.com/SocialiteProviders/Providers/blob/1cf2b81f84a85e89f8c96ed1ad7344d1fd3ae3f4/src/Azure/Provider.php#L4

PaddingtonBrown commented 1 week ago

https://github.com/SocialiteProviders/Providers/pull/1224

atymic commented 6 days ago

@PaddingtonBrown is there a reason why you can't use the microsoft provider? We are aiming to merge them soon.

PaddingtonBrown commented 5 days ago

@atymic the microsoft provider doesn't have the department field too. I would/could add it to that provider too.

I used azure because the documentation said it was aimed at private azure logins accounts rather than public ones that the microsoft provider was aimed at.

atymic commented 5 days ago

Please PR it there :)

PaddingtonBrown commented 5 days ago

@atymic here is a new pull request for the change https://github.com/SocialiteProviders/Providers/pull/1228

PaddingtonBrown commented 4 days ago

Hi @atymic at what point will this get released as a new package version on packagist? Cheers

atymic commented 3 days ago

Tagged sorry!