search

Socivo / ember-cli-intl-tel-input

An Ember.js wrapper for intl-tel-input library by Jack O'Connor (https://github.com/jackocnr/intl-tel-input). The plugin is based on ember-intl-tel-input by Justin Lau(http://justin-lau.github.io/ember-intl-tel-input). The plugin was created as the original plugin is no longer actively upgraded and mainted for new versions of Ember.js and jquery.
MIT License
4 stars 6 forks source link

Fresh install = jQuery errors #9

Open christophersansone opened 5 years ago

christophersansone commented 5 years ago

First, thanks for a great addon!

When I do a clean ember install ember-cli-intl-tel-input and then ember serve, an instance of {{intl-tel-input}} will throw the following error:

Uncaught TypeError: this.$(...).intlTelInput is not a function

For some reason, it looks like the NPM package for 1.0.14 currently includes an old version of components/intl-tel-input.js prior to the removal of jQuery in https://github.com/Socivo/ember-cli-intl-tel-input/commit/bf7756a9929ed2667c1774dab3766a970914bec9 . Yet, index.js is including the non-jQuery version.

Currently I am solving it by changing my package.json from this:

    "ember-cli-intl-tel-input": "^1.0.14"

to this: 

    "ember-cli-intl-tel-input": "socivo/ember-cli-intl-tel-input#master"

... but that's not really sustainable if this package continues to evolve.

Most of the addons I've seen will also create a git tag for each version, which would help see the changes across versions and easily get to a particular version and use it in package.json.

MojoJojo commented 5 years ago

Hi,

Thank you for the feedback. I shall look into it this evening.

christophersansone commented 5 years ago

Hi @MojoJojo , have you had a chance to check this out yet? I'm wondering if maybe it's just an invalid npm publish, and maybe a re-publish would resolve it?