SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
293 stars 91 forks source link

socket.constructor.name returns `Emitter` #33

Open mattkrick opened 8 years ago

mattkrick commented 8 years ago

Object.create doesn't assign anything to the prototype. There are 2 workarounds for this: Option 1 use new (technically, this is faster since V8 optimizes for it, but used so infrequently it really doesn't matter) Option 2 SCSocket.prototype.constructor = SCSocket + don't use anonymous function for creators (eg var SCSocket = function SCSocket(...`

use case: user passes in either a socket or a channel into a function. If socket do x, if channel, do y.