search

SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
292 stars 91 forks source link

Don't specify "socketcluster.js" as "main" in package.json #36

Closed Tenzer closed 7 years ago

Tenzer commented 8 years ago

This causes Node.js to load in the browserified version of the library, which gives errors about the code trying to access document, creating elements and other browser related stuff.

When main isn't specified in package.json, Node.js will by default read the index.js file which works just fine.

Tenzer commented 8 years ago

This is by the way also how it is done in the master branch of this repository.

jondubois commented 7 years ago

It looks like this PR was made when a lot of changes were happening and it appears to have been fixed. This was a valid issue though so thanks for the contribution.

jondubois commented 7 years ago

Oh, I just realized that this is for SC1. I think that very few people use SC1 now. I think most people who are using SC1 now have their own forks of SC which have diverged quite a bit (which is fine). I don't want to spent time maintaining a central SC1 repo anymore since it's been a very long time.

Sorry about that. Feel free building on top of your own fork though and feel free to link it from here if you like (if other people are interested in using it).