Don't lose the context - Githubissues

SocketCluster / socketcluster-client

JavaScript client for SocketCluster

MIT License

291 stars 92 forks source link

Don't lose the context #54

Closed mattkrick closed 8 years ago

mattkrick commented 8 years ago

Without context, there were no callbacks to call.

jondubois commented 8 years ago

@mattkrick I had to revert this change (it broke the channel watching) - The context has to be this._channelEmitter because we need to listen for that event here: https://github.com/mattkrick/socketcluster-client/blob/b3b36ad4b9643f5df14e0bfed0ccf22620bb4887/lib/scsocket.js#L917

What problem that this PR is trying to solve?