search

SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
291 stars 92 forks source link

replace lodash implementation of cloneDeep with a smaller implementation #71

Closed jscheel closed 7 years ago

jscheel commented 7 years ago

Not sure if you want to do this or not, but I figured I would go ahead and throw this PR together for review. Definitely needs heavy testing before merging, as well as consideration of other implementations.

Conversation found here: https://gitter.im/SocketCluster/socketcluster?at=587fb5ce074f7be763e9142e

Another suggestion by @mauritslamers is to consider SproutCore's implementation. I'm down for whatever works best and brings the filesize down as much as possible 😄

jondubois commented 7 years ago

@jscheel Looks good. I will test it out. Can you remove the changes to the build file and minified file from this PR (but leave eveything else the same)?

The reason is that we only build for each new release version - We don't build after every commit or else it takes a lot of extra storage. I'll have to update the version number before building anyway.

jscheel commented 7 years ago

@jondubois np, reverted and recommitted without the build files.

jondubois commented 7 years ago

@jscheel I completely forgot about that one. I finally tested and merged it in now. Thanks!