search

SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
291 stars 92 forks source link

Throw an error if user tries to specify protocol: 'https' or similar #74

Closed jondubois closed 6 years ago

jondubois commented 7 years ago

You're supposed to use secure: true for SSL/TLS. A lot of people use protocol: 'https' which is wrong. This is a common issue which people encounter so maybe we should throw an error if they try to do this?

MegaGM commented 7 years ago

Not an error but a warning?

jondubois commented 6 years ago

I think you fixed this @MegaGM :)

MegaGM commented 6 years ago

Well, I don't remember, thus I haven't fixed it. https://github.com/SocketCluster/socketcluster-client/pull/119