search

SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
293 stars 91 forks source link

Add Gulp and added more example usage #86

Closed odenktools closed 7 years ago

odenktools commented 7 years ago

Helloo SC! i made some change into your great work, maybe you can review my works. Thanks!

jondubois commented 7 years ago

@odenktools Nice. I left a comment on the diff. I noticed that this introduces a lot of dependencies.

jondubois commented 7 years ago

@odenktools I'll try to merge it this weekend after I've reviewed it more.

odenktools commented 7 years ago

Wooww great! thanks @jondubois

jondubois commented 7 years ago

I made some additional comments @odenktools. Also, thanks for removing the dependencies earlier.

odenktools commented 7 years ago

@jondubois All done

jondubois commented 7 years ago

@odenktools Ok merged, thanks for that.

jondubois commented 7 years ago

@odenktools What's your operating system? I couldn't use the current build process using npm run build because it adds some ^M characters (Windows line endings) to the end of the lines in part of the output socketcluster.js file. Is it possible to remove those from the output? The issue doesn't happen when I just run browserify -s socketCluster index.js > socketcluster.js directly on my Ubuntu machine.

jondubois commented 7 years ago

@odenktools Nevermind, I think I'm having a separate issue...