search

SocketCluster / socketcluster-client

JavaScript client for SocketCluster
MIT License
291 stars 92 forks source link

Add ESLint for CodeQuality Tools #90

Closed odenktools closed 6 years ago

odenktools commented 6 years ago

Helloo @jondubois im added eslint for codequality, what do you think?

jondubois commented 6 years ago

@odenktools I think this might be useful at some point in the future, but for now I'd prefer to wait a bit before introducing more dependencies to solve a problem which doesn't exist yet.

Contributors so far have been adhering to the code conventions and styling and so I don't feel that it's something that needs to be automated at this stage.

I'm happy to leave this PR open to revisit at a later date. If anyone feels strongly about this PR, please leave a comment below.

I'd be happy to merge this is enough people feel that linting would add value to this project.

odenktools commented 6 years ago

Sorry @jondubois for late reply.. ok great thinks! i hope all contributors like this PR.

jondubois commented 6 years ago

Lucky that this didn't get merged https://github.com/eslint/eslint-scope/issues/39 ;p

odenktools commented 6 years ago

Yes its very very lucky :+1: time to remove this PR

jondubois commented 6 years ago

@odenktools I still think we can consider ESLint but I think that the lesson is that we should be careful about adding too many dependencies to a project - There's a hidden risk/cost.

odenktools commented 6 years ago

@jondubois Thanks for lesson, yes i aggree with you, too many dependencies make project more complicated