search

SocketCluster / socketcluster

Highly scalable realtime pub/sub and RPC framework
https://socketcluster.io
MIT License
6.15k stars 314 forks source link

Too many issues with eslint #450

Closed leduong closed 6 years ago

leduong commented 6 years ago

Dear Socket Cluster Team

I'm has been added eslint and test. I like a light framework socket nodejs.

https://travis-ci.org/leduong/socketcluster/jobs/440015693

jondubois commented 6 years ago

Thanks, this was useful. I fixed several of the linting issues. Some of them were a bit too trivial though so I didn't implement all of them. ESLint is a useful tool to guide decisions but it should not be a replacement for common sense.