SocketCluster / socketcluster

Highly scalable realtime pub/sub and RPC framework
https://socketcluster.io
MIT License
6.15k stars 314 forks source link

HTTP/2 Support #465

Open ayZagen opened 5 years ago

ayZagen commented 5 years ago

Hello, when I try to use http/2 with socketcluster, clients cannot connect to sc with the http error 403. On the server side I get following error:

[Error] Error: read ECONNRESET
    at TLSWrap.onStreamRead (internal/stream_base_commons.js:162:27)

Websocket support is implemented in nodejs http2 module. See @nodejs/node#23284 However, ws module hasn't implemented it yet. See @websockets/ws#1458

Could you implement it on sc-uws ?

Thanks.

jondubois commented 5 years ago

@ayZagen SC has moved away from using sc-uws as the default. It's just too much effort to maintain; each node.js version requires new builds. uWS is an optimization for more advanced users.

I'd prefer to wait for the ws module to add it. Please let me know if you manage to get SC to work with HTTP2. Feel free to post recommendations here.