SocksTheWolf / AntiScamBot

A discord bot that shares commission scammer ban lists
https://scamguard.app/
MIT License
5 stars 3 forks source link

Refactor: Database Schema #7

Closed SocksTheWolf closed 6 months ago

SocksTheWolf commented 9 months ago

This requires tweaking the database to migrated to one that has better typing/formatting rules. Right now, it's kind of a mess, and even worse if we ever have to upgrade the server.

Look into ways to potentially make this easier to work with that can also build queries. There are a few python libraries that can help.

SocksTheWolf commented 9 months ago

Dropping original above comment. I was under the impression Railways pricing worked on the same system as Digital Ocean, and it does not. It’s actually potentially more expensive.

SocksTheWolf commented 9 months ago

I’m wondering if this ticket should be blocked on having the unit testing solidified first #19

SocksTheWolf commented 9 months ago

Look into sqlalchemy:

user4752 commented 9 months ago

Partially implemented conversion to sqlalchemy here: https://github.com/SocksTheWolf/AntiScamBot/compare/main...user4752:AntiScamBot:db-refactor

Just need to update Discord.py to accept the new data format being returned

Will make future pull request when complete

SocksTheWolf commented 9 months ago

@user4752 skimmed this so far, lots of progress here. Looking forward to reviewing the pr!