enable display of multiple locations per post

[wildcomputations]

This pull request is intended as a discussion rather than a complete feature I expect you to accept.

My blog posts have multiple points of interest. I want to display all of them in the overview map. This branch adds the ability to display multiple markers for a single post in the [travelers-map] short code. I don't know how to do the front end work to make so people can add multiple locations in the admin page. It will probably involve add_post_meta with unique=false, and then update_post_meta for the user to update just one of the locations.

I realize that one of the features of the travelers-map plugin is that it is simple, so you may not wish to add this complexity. I did not find any other plugins with support for multiple geo-tag locations for a post.

For myself, I use the wp-gpx-maps plugin to insert GPS tracks into my posts. I plan to write a function to extract key locations from the GPS tracks and insert them into the post meta table in the format [travelers-map] expects.

Thanks for considering my idea, Emilie

[Socrapop]

Dear Emilie,

Yes, this is a feature I already though about a year ago and postponed it to version 2. In term of development, it will be easy, but very long. I think a feature like this would mean to rewrite every part of the plugin.

It is also a very complexe feature in term of UX, let me explain:

• With the default shortcode [travelers-map], should all the markers be visible, or just the "main" marker? Maybe that can be a plugin option or a shortcode parameter. It could also be: "only the main marker, unless 'this_post=true'".

• When you click on a "child marker", should the other markers from this post be highlighted, or linked with a line? And what about the zoom if the other markers are too far away? Right now the zoom level never changes when clicking on a marker, only on a cluster.

• How can I let the user choose multiple markers in the backend, and how can they edit them? I could add a clickable list, with a checkbox to select the main marker. Or it could be done directly on the map, clicking on an existent marker would select it, and then clicking on the map would move it around, but then you would have to add a marker by cliking a button. I think this would be the best way to do it.

• Moreover, I think each marker should have a "custom text" or a title to differenciate them from the others. This is a part of my next big update. Also, each marker could have a different icon.

I think I forgot some points, but it's enough to understand :) I'm not against the feature, it's clearly time to refactor anyway, but I have to find the time to do it :) And do it properly to match the simplicity I like to offer with Travelers Map.

[wildcomputations]

Thanks for your response. I tried playing around with the code to add a second input map on the admin page, but with no luck. I'll have to wait and see what you make.

For my use, I would not need a main vs child markers. All markers can have equal weight. For example, I would like to keep track of the New Hampshire 4,000 foot mountains that I have climbed. For a hike summitting multiple mountains, I would put a marker on the top of each, and would like all of them to show equally on the map.

Unrelated to the above, I just upgraded to version 1.11.0 and it appears you broke the disable_clustering=true argument to the short code. When I add that argument, the map does not load at all. See attached screen shot.

Emilie

On Thu, Jul 30, 2020 at 7:25 AM Camille V notifications@github.com wrote:

Dear Emilie,

Yes, this is a feature I already though about a year ago and postponed it to version 2. In term of development, it will be easy, but very long. I think a feature like this would mean to rewrite every part of the plugin.

It is also a very complexe feature in term of UX, let me explain:

-

With the default shortcode [travelers-map], should all the markers be visible, or just the "main" marker? Maybe that can be a plugin option or a shortcode parameter. It could also be: "only the main marker, unless 'this_post=true'".

When you click on a "child marker", should the other markers from this post be highlighted, or linked with a line? And what about the zoom if the other markers are too far away? Right now the zoom level never changes when clicking on a marker, only on a cluster.

How can I let the user choose multiple markers in the backend, and how can they edit them? I could add a clickable list, with a checkbox to select the main marker. Or it could be done directly on the map, clicking on an existent marker would select it, and then clicking on the map would move it around, but then you would have to add a marker by cliking a button. I think this would be the best way to do it.

Moreover, I think each marker should have a "custom text" or a title to differenciate them from the others. This is a part of my next big update. Also, each marker could have a different icon.

I think I forgot some points, but it's enough to understand :) I'm not against the feature, it's clearly time to refactor anyway, but I have to find the time to do it :) And do it properly to match the simplicity I like to offer with Travelers Map.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Socrapop/travelers-map/pull/11#issuecomment-666308260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6YAC6TRATTLLZGKSSULELR6FJ7DANCNFSM4PLDKYJQ .

[Socrapop]

Dear Emilie,

First of all, thank you for the bug report, I had someone on the forum with a broken map, that could be the problem (but it's strange I did not touch the code for the clustering)

I understand you had some difficulties, my code lacks visibility, and this update needs a lot of rework on both PHP and JS files. However, this is the next update ;) (I need this feature too on my blog, for road trips with multiple steps).

But first, I need to fix this bug!

[BaptisteOrieuxDecathlon]

I've seen you are already developping this plugin v2; AWESOME !

One feature I would love to have, to enhance this one, would be to upload & display a GPX file. I'm into hiking and I would love to save a GPX for some of my posts to display the path I'm following and to help people locate myself on track

I hope something like that would be possible ;) Good luck on your code !

[Socrapop]

Dear @BaptisteOrieuxDecathlon,

Yes, this is a nice feature I will certainly add, it would nicely work with the multimarker feature. As always, I don't know when, but that's on my shortlist after fixing the V2 potential bugs and enhancing the multimakers feature.

@wildcomputations It's been a while, but I think V2 is ready ;) I already installed it on my personnal blog (not yet using it). You can test the feature by downloading this branch: https://github.com/Socrapop/travelers-map/tree/2.0-Multiple-markers

Have a nice day, Camille

[Socrapop]

22 V2.0.0 is out now with this feature request :)

[wildcomputations]

Dear Camille,

Thank you very much. I finally had time to test it over the holidays, and it works great. I even tried it on a post with 12 locations.

I noticed that if I add the flag centered_on_this=true to the shortcode, it centers on the first marker. I think that's fine. Could you add a note to the help text in the shortcode generator?

Emilie

On Sun, Sep 26, 2021 at 9:27 AM Camille V @.***> wrote:

Closed #11 https://github.com/Socrapop/travelers-map/pull/11.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Socrapop/travelers-map/pull/11#event-5361303841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6YAC4GPWGP5OF7GBGHN5TUD4NSLANCNFSM4PLDKYJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.