Closed Confuset closed 6 years ago
Would supporting NetStandard 2.0 do the trick? I think Microsoft is deprecating PCLs in favor of NetStandard.
On Sat, Oct 21, 2017 at 3:30 PM Confuset notifications@github.com wrote:
hey is it possible to release a version of SodiumFRP that supports PCL? i want to use it with Xamarin.Forms but this seems to work only with PCL.
I asked the guys from priority queue to also support PCL and they did it :-) BlueRaja/High-Speed-Priority-Queue-for-C-Sharp#18 https://github.com/BlueRaja/High-Speed-Priority-Queue-for-C-Sharp/issues/18
so far you only have to add a new project (Xamarin library/PCL), add all files as references (so you dont have them twice) and install/update priority queue. That is basically it… iam not that familiar with nuget, otherwise i would create a pull request for this. but since the steps are pretty simple i think this is ok…
what do you think?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SodiumFRP/sodium/issues/114, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbTOEyjQIL-0HcyXX0H3jLwWGCOBiDMks5sukY-gaJpZM4QBr5u .
I think so too. Just tried it, and the funny thing is that older uwp/uap do not support .NetStandard. android and iPhone work without any problems.
Also you will not be able to properly reference High Speed Priority Queue as this does not support .NetStandard…
but i think i can workaround. i just added sodium as submodule into my project and that seems to work like a charm :-)
Also you will not be able to properly reference High Speed Priority Queue as this does not support .NetStandard…
Actually, it does! I added support for legacy .Net 2.0, .Net 4.0, PCL, and UWP, as well as the new .Net Standard 1.0 (which is forward-compatible with .Net Standard 2.0)
Awesome! I was going to look into this more myself, but thanks for saving me the time, BlueRaja. Also, thank you for providing a great library for us to leverage.
It looks like supporting .NET Standard 1.0 is the way to go, as that would mean we would be providing support for the largest number of platforms.
https://docs.microsoft.com/en-us/dotnet/standard/net-standard
On Sat, Oct 21, 2017, 5:48 PM BlueRaja notifications@github.com wrote:
Also you will not be able to properly reference High Speed Priority Queue as this does not support .NetStandard…
Actually, it does! I added support for legacy .Net 2.0, .Net 4.0, PCL, and UWP, as well as the new .Net Standard 1.0 (which is forward-compatible with .Net Standard 2.0)
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/SodiumFRP/sodium/issues/114#issuecomment-338434766, or mute the thread https://github.com/notifications/unsubscribe-auth/AEbTOLxouA3GajCi1fj8l8pT9PlyKcABks5sumaYgaJpZM4QBr5u .
ha. that was my mistake..i did not think about using older .netstandard :-( stupid me
keep in mind though that you are using System.Threads which can be problematic/not supported befor .Net Standard 2.0 https://github.com/dotnet/standard/blob/master/docs/versions/netstandard1.0_ref.md
https://github.com/dotnet/standard/tree/master/docs/versions https://raw.githubusercontent.com/dotnet/standard/master/docs/versions/netstandard2.0_diff.md search for class Thread
Or take a look here https://apisof.net/catalog/System.Threading.Thread
Just created a pull request for .Net Standard 1.1
This will be covered by #121.
hey is it possible to release a version of SodiumFRP that supports PCL? i want to use it with Xamarin.Forms but this seems to work only with PCL.
I asked the guys from priority queue to also support PCL and they did it :-) https://github.com/BlueRaja/High-Speed-Priority-Queue-for-C-Sharp/issues/18
so far you only have to add a new project (Xamarin library/PCL), add all files as references (so you dont have them twice) and install/update priority queue. That is basically it… iam not that familiar with nuget, otherwise i would create a pull request for this. but since the steps are pretty simple i think this is ok…
what do you think?