SodiumFRP / sodium

Sodium - Functional Reactive Programming (FRP) Library for multiple languages
http://sodium.nz/
Other
848 stars 138 forks source link

Fix SampleLazy bug #131

Closed jam40jeff closed 6 years ago

jam40jeff commented 6 years ago

SampleLazy computes its value as part of the "last" phase of a transaction. However, if the value constructed contains more FRP objects to add to the graph, this can cause a problem, as those objects will not have their prioritized actions run since the "last" phase is after the "prioritized loop". The fix for this is to make a new "sample" phase which runs after all prioritized actions, but is still part of the "prioritized loop" so that it may add further actions to the prioritized queue to be run.

jam40jeff commented 6 years ago

Fixed by the following commits:

73cbcf9 c1b2aa0 523c276 5a3504f

the-real-blackh commented 6 years ago

I've replaced this bug with ones for individual languages: #124 #125