【ユーザー登録】is_signed_upをsigned_up_atにする #245

[hosakou]

実装内容

close #245

• is_signed_up を signed_up_at に変更しました。

• メールの認証が完了したときに signed_up_at に値をセットするように変更しました。

• composer migrate 後に UPDATE `users` SET `signed_up_at` = CURRENT_TIMESTAMP WHERE `email_verified_at` IS NOT NULL AND `univemail_verified_at` IS NOT NULL の実行をお願いします！

懸念点

レビュワーに見て欲しい点

• 不要な箇所でアップデートが行われないか

参考URL

[codecov[bot]]

Codecov Report

Merging #278 into master will decrease coverage by 0.38%. The diff coverage is 0%.

@@             Coverage Diff              @@
##             master     #278      +/-   ##
============================================
- Coverage     25.37%   24.98%   -0.39%     
- Complexity      444      447       +3     
============================================
  Files           112      112              
  Lines          1348     1353       +5     
============================================
- Hits            342      338       -4     
- Misses         1006     1015       +9

Impacted Files	Coverage Δ	Complexity Δ
app/Http/Middleware/EnsureEmailIsVerified.php	50% <ø> (-5.56%)	3 <0> (ø)
app/Http/Controllers/Auth/Email/VerifyAction.php	0% <0%> (ø)	9 <0> (+2)	:arrow_up:
app/Eloquents/User.php	46% <0%> (-8.17%)	20 <2> (+1)
app/Services/Auth/EmailService.php	0% <0%> (ø)	8 <1> (ø)	:arrow_down:
app/Http/Controllers/Users/UpdateInfoAction.php	0% <0%> (ø)	14 <0> (ø)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0d9dfc3...0115bba. Read the comment docs.

[SofPyon]

本番環境にも

UPDATE users SET signed_up_at = CURRENT_TIMESTAMP WHERE email_verified_at IS NOT NULL AND univemail_verified_at IS NOT NULL

流しました！