SofPyon / inaka-portal

[DEPRECATED] inaka-portal は PortalDots に改称し、リポジトリも移転します。移行先➡️
https://github.com/portal-dots/PortalDots
MIT License
5 stars 0 forks source link

【Laravel】6.x にアップグレード #54 #286

Closed hosakou closed 4 years ago

hosakou commented 4 years ago

実装内容

close #54

懸念点

レビュワーに見て欲しい点

codecov[bot] commented 4 years ago

Codecov Report

Merging #286 into master will decrease coverage by 0.14%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #286      +/-   ##
============================================
- Coverage     24.81%   24.66%   -0.15%     
  Complexity      449      449              
============================================
  Files           113      113              
  Lines          1362     1362              
============================================
- Hits            338      336       -2     
- Misses         1024     1026       +2
Impacted Files Coverage Δ Complexity Δ
app/Exceptions/Handler.php 100% <ø> (ø) 2 <0> (ø) :arrow_down:
app/Http/Middleware/Authenticate.php 0% <ø> (ø) 2 <0> (ø) :arrow_down:
app/Http/Requests/Forms/BaseAnswerRequest.php 69.23% <100%> (ø) 6 <4> (ø) :arrow_down:
app/Console/Kernel.php 50% <0%> (-33.34%) 2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88f2743...343de9c. Read the comment docs.

hosakou commented 4 years ago

@SofPyon メール認証のメールに今まで出てなかったものが出てしまい、修正しようとしたのですがうまく解決できなかったので、お願いしてもよろしいでしょうか? image

hosakou commented 4 years ago

@SofPyon ありがとうございます!!

再度、動作確認しました!大丈夫そうです!

SofPyon commented 4 years ago

@hosakou ありがとう! マージ&デプロイしてみて様子見してみます!