search

SofPyon / inaka-portal

[DEPRECATED] inaka-portal は PortalDots に改称し、リポジトリも移転します。移行先➡️
https://github.com/portal-dots/PortalDots
MIT License
5 stars 0 forks source link

NEWバッジ #258 #287

Closed hosakou closed 4 years ago

hosakou commented 4 years ago

実装内容

close #258

懸念点

レビュワーに見て欲しい点

参考URL

codecov[bot] commented 4 years ago

Codecov Report

Merging #287 into master will decrease coverage by 0.09%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
- Coverage     24.81%   24.72%   -0.10%     
- Complexity      446      448       +2     
============================================
  Files           112      113       +1     
  Lines          1358     1363       +5     
============================================
  Hits            337      337              
- Misses         1021     1026       +5
Impacted Files Coverage Δ Complexity Δ
app/Eloquents/Concerns/IsNewTrait.php 0.00% <0.00%> (ø) 2.00 <2.00> (?)
app/Eloquents/Document.php 75.00% <ø> (ø) 3.00 <0.00> (ø)
app/Eloquents/Page.php 100.00% <ø> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a1b431e...447e440. Read the comment docs.

SofPyon commented 4 years ago

@hosakou レビュー遅れて申し訳ない！ インターン中なので週末にできたらレビューします！

hosakou commented 4 years ago

@SofPyon

修正しました！

作成から3日以内かどうか判断する関数だけ1つにまとめました！