Fix wrong assets source

olivier-roussel commented 1 year ago

Propagates #112 and #113 into master. The softprops/action-gh-release Github action used in the CI to deploy assets was incorrectly configured to the master branch (default behavior), instead of the current release set by the sofa_branch field in the build-and-test matrix. This lead to the following undesired behavior:

source code archives (zip and tar) were generated from master branch instead of release branch. Other assets (releases for Windows, Linux and MacOS) were generated from correct branch.
release tag pushed by this action (tag in the form release-<version>) was incorrectly set to master branch, which is invalid when current release is not master (such as v<version>)

damienmarchal commented 11 months ago

Hello @olivier-roussel

Sorry for waknig up that late. Is this PR still needed ?

olivier-roussel commented 11 months ago

Yes, otherwise source code assets for releases that are not on master will be incorrectly be taken from master (repo default branch), instead of the branch / commit pointed by target_commitish (see https://github.com/softprops/action-gh-release#inputs).

SofaDefrost / STLIB

Fix wrong assets source #114