search

SofaDefrost / SofaGym

Machine Learning framework for Sofa
68 stars 10 forks source link

Fix dt in envs #16

Closed hunoutl closed 1 year ago

hunoutl commented 1 year ago

In #15 dt was missing. simulta.py need it but was not in env config. Strange how everythings was working before ?! I's not mandatory in AbstractEnv config class. Should it ?

EtienneMenager commented 1 year ago

Yes, it is strange. We have to add it in AbstractEnv.

alxbilger commented 1 year ago

@EtienneMenager would you like that this PR adds dt in AbstractEnv? Or it's ok to merge it like that?

EtienneMenager commented 1 year ago

I think it is better to integrate it now. There might be problems later...

alxbilger commented 1 year ago

Superseded by #19