Closed techytoes closed 6 years ago
Hi @firedranzer,
Thanks for the PR, @ErwanDouaille can you handle the merge process ?
DM.
Hey :)
Of course I will review it tonight. There is some polish needed.
Le jeu. 5 juil. 2018 à 10:33, Damien Marchal notifications@github.com a écrit :
Hi @firedranzer https://github.com/firedranzer,
Thanks for the PR, @ErwanDouaille https://github.com/ErwanDouaille can you handle the merge process ?
DM.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/SofaDefrost/sofa/pull/18#issuecomment-402647078, or mute the thread https://github.com/notifications/unsubscribe-auth/AFT6lw_6PtE_K_1hMbkOr2xIHVUX2riXks5uDc9RgaJpZM4VCRfo .
@ErwanDouaille I have added all the required changes. I tested this on my machine locally and everything is working good. Please review this.
@firedranzer cool ! Does everything works perfectly ?
@ErwanDouaille Yes! Everything works perfectly. 😄
Hey @ErwanDouaille ! I have added docs and examples. I think this is complete. Can you have a look at it for one last time? 😉
This PR contains the VRPN protocol implementation inside communication plugin which was a part of My Google Summer of Code Project.
This PR:
Reviewers will merge only if all these checks are true.