SoftCreatR / imei

IMEI - ImageMagick Easy Install
ISC License
293 stars 35 forks source link

Install of dependencies fails when etckeeper prevent auto commit #102

Closed xeyownt closed 9 months ago

xeyownt commented 10 months ago

Hello,

I noticed a minor failure in case we have etckeeper installed and configured to prevent auto-committing before apt install (ie AVOID_COMMIT_BEFORE_INSTALL=1 in file /etc/etckeeper/etckeeper.conf).

In the log we see the message

** etckeeper detected uncommitted changes in /etc prior to apt run
** Aborting apt run. Manually commit and restart.

etckeeper complains because it sees a new file apt/sources.list.d/imei.list that is added before apt install is run.

As a result the dependencies are not installed, and install / build will fail at some points, or the built binary may not contains all the supported delegates.

A workaround is simply to set the variable AVOID_COMMIT_BEFORE_INSTALL=0 in file /etc/etckeeper/etckeeper.conf prior launching imei.sh.

Thanks for the very handy script.