SoftCreatR / imei

IMEI - ImageMagick Easy Install
ISC License
293 stars 35 forks source link

Wrong requires when using checkinstall #113

Closed gionn closed 2 months ago

gionn commented 2 months ago

Hello,

while trying to build on debian 12 using imei HEAD version I get:

checkinstall 1.6.3, Copyright 2010 Felipe Eduardo Sanchez Diaz Duran
           This software is released under the GNU GPL.

/usr/bin/checkinstall: line 606: libwebp-dev,libjpeg-dev,libzip-dev,libice-dev,libsm-dev,libxml2: command not found
/usr/bin/checkinstall: line 606: libxml2-dev: command not found

*****************************************
**** Debian package creation selected ***
*****************************************

This package will be built according to these values:

0 -  Maintainer: [ root@33cbecac4ed1 ]
1 -  Summary: [ image manipulation programs (IMEI v6.11.2) ]
2 -  Name:    [ imei-imagemagick ]
3 -  Version: [ 7.1.0-16 ]
4 -  Release: [ imei6.11.2 ]
5 -  License: [ Apache-2.0 ]
6 -  Group:   [ checkinstall ]
7 -  Architecture: [ arm64 ]
8 -  Source location: [ ImageMagick-7.1.0-16 ]
9 -  Alternate source location: [  ]
10 - Requires: [  ]
11 - Recommends: [ imei-libaom,imei-libheif,imei-libaom,imei-libjxl ]
12 - Suggests: [  ]
13 - Provides: [ imagemagick (= 7.1.0-16),imagemagick-7.q16 (= 7.1.0-16),libmagickcore-7.q16 (= 7.1.0-16),libmagickwand-7.q16 (= 7.1.0-1
6) ]
14 - Conflicts: [ imagemagick ]
15 - Replaces: [  ]

Enter a number to change any of them or press ENTER to continue:

Installing with make install...

notice the empty Requires and the spurious command not found before.

This regression has been introduced in (| get interpreted as pipe shell):

https://github.com/SoftCreatR/imei/commit/671fb0c8d82fded66a6c549cc155c672b02bf6f6#diff-49155aca3829a4bb7ba8eb07d3f0b772dc7dad1fe7e04f0db1d1f8dc9485c0c1R1016

Using imei v6.10.5 workaround the issue (still can't build package, will try to raise another issue).

SoftCreatR commented 2 months ago

This regression has been introduced in (| get interpreted as pipe shell):

I wonder, if escaping it would do the trick.

gionn commented 2 months ago

looks like YES! I will rise a PR

checkinstall 1.6.3, Copyright 2010 Felipe Eduardo Sanchez Diaz Duran
           This software is released under the GNU GPL.

*****************************************
**** Debian package creation selected ***
*****************************************

This package will be built according to these values:

0 -  Maintainer: [ root@33cbecac4ed1 ]
1 -  Summary: [ image manipulation programs (IMEI v6.11.2) ]
2 -  Name:    [ imei-imagemagick ]
3 -  Version: [ 7.1.0-16 ]
4 -  Release: [ imei6.11.2 ]
5 -  License: [ Apache-2.0 ]
6 -  Group:   [ checkinstall ]
7 -  Architecture: [ arm64 ]
8 -  Source location: [ ImageMagick-7.1.0-16 ]
9 -  Alternate source location: [  ]
10 - Requires: [ libraqm0,libgomp1,libfftw3-dev,liblcms2-2,libfontconfig1,libxext6,libltdl7,liblqr-1-0-dev,webp|libwebp-dev,libjpeg-dev,
libzip-dev,libice-dev,libsm-dev,libxml2|libxml2-dev ]
11 - Recommends: [ imei-libaom,imei-libheif,imei-libaom,imei-libjxl ]
12 - Suggests: [  ]
13 - Provides: [ imagemagick (= 7.1.0-16),imagemagick-7.q16 (= 7.1.0-16),libmagickcore-7.q16 (= 7.1.0-16),libmagickwand-7.q16 (= 7.1.0-1
6) ]
14 - Conflicts: [ imagemagick ]
15 - Replaces: [  ]

Enter a number to change any of them or press ENTER to continue:

Installing with make install...