search

SoftCreatR / imei

IMEI - ImageMagick Easy Install
ISC License
305 stars 35 forks source link

Add support for JPEG XL #13

Closed jackyhallyday closed 3 years ago

jackyhallyday commented 3 years ago

Hello,

JPEG XL (https://gitlab.com/wg1/jpeg-xl) support has just been merged to Chromium and can be enabled with a flag.

ImageMagick mentions JPEG XL support (https://imagemagick.org/script/formats.php) : JXL RW JPEG XL image coding system Requires the JPEG XL delegate library.

Is there a way to add this library during the install of imei, so it would support JPEG XL, too?

SoftCreatR commented 3 years ago

Hi,

IMEI should support it very soon. I just need to perform a few more tests.

SoftCreatR commented 3 years ago

Done :)

https://github.com/SoftCreatR/imei/discussions/15

jackyhallyday commented 3 years ago

Wow! That's great, thank you!

jackyhallyday commented 3 years ago

...unfortunately, it didn't work for me.

At first it seems ok during the installation. It didn't, so I also tried to --force to build everything again. No problem, again: Installing dependencies [OK] Building aom [OK] Building libheif [OK] Building jpegxl [OK] Building ImageMagick [OK] Verifying installation [OK]

convert seems to work, but it's generating "classic" JPG files (with a .jxl extension).

> /usr/local/bin/convert -list format JXL is not in the list

> /usr/local/bin/convert -version Version: ImageMagick 7.0.11-6 Q32 x86_64 2021-03-28 (...) Delegates (built-in): bzlib cairo djvu fftw fontconfig freetype heic jbig jng jp2 jpeg jxl lcms lqr ltdl lzma openexr pangocairo png raqm raw rsvg tiff webp wmf x xml zip zlib

> ls -l /usr/local/lib/ImageMagick-7.0.11/modules-Q32HDRI/coders jxl.la and jxl.lo are there.

Everything seems fine.

Note: I had already installed JPEG XL from the GitLab sources, and I am already producing JXLs by generating PNGs with ImageMagick, then convert them with cjxl. I mean: it definitely compiles on my server. And the build process of ImageMagick seems normal.

That might be an ImageMagick bug, maybe? I don't know.

SoftCreatR commented 3 years ago

See https://gitlab.com/wg1/jpeg-xl/-/issues/207

It seems, that IM is currently not fully compatible with JXL.

jackyhallyday commented 3 years ago

Great news! https://twitter.com/JackyHallyday/status/1382434351904854025

SoftCreatR commented 3 years ago

Well, i don't understand, why it requires a tweet, to get their attention, but better than nothing, i guess 👍

SoftCreatR commented 3 years ago

The issue reported at JPEG XL has been labeled as fixed, but there hasn't been any commit yet. So we'll have to wait for the next release, I guess.

SoftCreatR commented 3 years ago

Today, a new commit has been pushed to the JXL repo: https://gitlab.com/wg1/jpeg-xl/-/commit/ab7c5e9b6795134377aa4846ceaae2c5bc504f76

I've rebuilt IM 7.0.11-8 using it, but still no luck.

SoftCreatR commented 3 years ago

@jackyhallyday Just FYI: It works now without any changes at my end using libjxl 0.3.7 and IM 7.0.11-13.