search

SoftDev4Research / 4OSS-lesson

The overall aim of these 4OSS in the shape of training materials will contribute to make research software FAIR.
https://SoftDev4Research.github.io/4OSS-lesson
Other
23 stars 22 forks source link

Episode Contributions - review after the hackathon utrecht August 1-3 #55

Open orchid00 opened 6 years ago

orchid00 commented 6 years ago

@Pfern @fmichonneau @malvikasharan

Thanks for your contributions to the Contributions episode. I just merged the PR.

24 and addressed the smaller changes.

How to continue? Please see the comments listed below. The order is: Number, topic and what to change and who suggested it. If you rather not address any of the TODOs please share the reasoning.

General comments: We could work on one point each as they are four. Or we could discuss here in comments each point and then proceed. Also I suggest giving it a full review now that is merged, and add points that need to be modified. If you see any short typos, please send smaller PR's.

Reviews numbered

  1. To allow meaningful contributions, it is crucial to make your project FAIR

TODO: @mkuzak: how do the meaningful contributions are connected to being FAIR? @orchid00: also I'm not sure how to make the connection, but there might be sub points to relate.

  1. If you are not yet convinced that having your project open for contributions is

TODO: @mkuzak: I don't know, how me not being sure about the advantages of opening the project has to do with questions on how people can contribute.

  1. For the developers to make relevant contributions, it is also worth thinking...

TODO: @mkuzak: This is a very long and hard to understand sentence. Can you rewrite and simplify it?

  1. Technical requirements (software versions, space, etc) TODO: @mkuzak: what kind of space? hard drive space?
orchid00 commented 6 years ago

Hello team! @Pfern @fmichonneau @malvikasharan Can we work on this on Oct 3rd? allowing for time differences.