SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
7.33k stars 871 forks source link

Brim (Brim-Object gap?) doesn't account for Elephants-foot compensation...this creates a gap between brim and object #3720

Open PhilBaz opened 10 months ago

PhilBaz commented 10 months ago

OrcaSlicer Version

1.9

OS version

win 10

Additional system information

good

Printer

Voron 2.4

How to reproduce

Add elephants-foot compensation and brim and slice.... If Brim-Object gap is zero there should be no gap. but there is! This gap is caused be Elephant foot compensation, and can be closed by reducing this to zero.

Screenshot 2024-01-17 103318

Actual results

There is a gap

Expected results

No gap, brim should touch, or be controlled entirely by brim-object gap

Project file & Debug log uploads

brim issue.zip

Checklist of files to include

PhilBaz commented 8 months ago

Just bumping this as its a proper bug and should be pretty easy to fix....I think?

PhilBaz commented 8 months ago

Bumping as this is a pretty major bug.

idmadj commented 8 months ago

Can repro on 1.9.1. Enabling Elephant foot compensation renders all brim types non-functional.

PhilBaz commented 8 months ago

Yes, just to clarify here are some images that show the issue. The brim should follow the (elephants foot compensation/ scaling ) base layer. a b

cbaugher commented 6 months ago

Concur. Issue still exists in V2.0.0

PhilBaz commented 6 months ago

@cbaugher I have to think this is one of the largest actual bugs in Orca. This is primary functionality breaking.

RoboCrafty commented 5 months ago

image I still have the gap even with elephant foot compensation set to 0. Brim-Object distance is 0 too. :/

PhilBaz commented 5 months ago

@RoboCrafty Then you must have a value in the brim offset. That's not a bug. Just the elephant foot compensation.

RoboCrafty commented 5 months ago

@PhilBaz I don't get it? I thought to remove the gap between the brim and the object the elephant foot compensation had to be set to 0 because of a bug? And here I have the gap even with it set to 0

PhilBaz commented 5 months ago

@RoboCrafty Screenshot 2024-05-27 094904

RoboCrafty commented 5 months ago

@PhilBaz Yesss I know that 😅, I mentioned I had that set to 0 and there still is a gap.

PhilBaz commented 5 months ago

@RoboCrafty Ohh, okay sorry. If you have that set to zero as well as elephants-foot then there should not be a gap. Maybe a bug then.

Just making sure you also didn't change any per-object settings?

PhilBaz commented 5 months ago

@HeavilyModdedEnder3 Too much and confuses the issue...please don't hijack this bug fix request, start your own thread. This is not what we are asking for. Please delete your post here and start your own thread.

The bug fix is simply that the brim will account for elephants foot compensation so the brim is not detached. That's all.

neo-jayfeather commented 4 months ago

https://wiki.bambulab.com/en/software/bambu-studio/parameter/elephant-foot The last two screenshots seem to indicate that BBL does not plan on fixing this issue on their slicer. Just a note, but this does seem fixable by editing the .\src\libslic3r\brim.cpp and maybe the elephants foot compensation one (.\src\libslic3r\ElephantFootCompensation.cpp).

PhilBaz commented 4 months ago

@neo-jayfeather

Ahhh, what a horrible decision... It should 'Just work'. Decoupling elephant's foot from brim is obviously the wrong approach. Very much hope to see this corrected in Orca.

brunetton commented 4 months ago

Same here image image (I made elephant foot compensation large to make the problem obvious)

neo-jayfeather commented 4 months ago

I was reading the prusaslicer wiki and they stated that elephant's foot compensation should squish the filament out enough so that the brim should be properly aligned-- I don't know if that applies, but that may be why no one (these slicers) have changed it.

idmadj commented 4 months ago

I was reading the prusaslicer wiki and they stated that elephant's foot compensation should squish the filament out enough so that the brim should be properly aligned-- I don't know if that applies, but that may be why no one (these slicers) have changed it.

Sorta makes sense. If the brim doesn't connect, it's theoretically a sign that efc is set too high.

That being said, elephant foot happens as the weight of the model squishes out the bottom (efc is not meant to compensate for poor z-offset). By the time that happens the first layer has cooled down to the temperature of the bed rather than the nozzle's, so not much inter-line adhesion will take place. Also it's entirely possible that lifting will happen before the model gets a chance to elephant foot and connect with the brim. In both cases the brim will not be given a chance to do its job properly.

github-actions[bot] commented 1 month ago

Orca bot: this issue is stale because it has been open for 90 days with no activity.

PhilBaz commented 1 month ago

Bump...this should be fixed.

PhilBaz commented 1 month ago

@neo-jayfeather No, this was originaly a Cura feature and there he implementation is correct...IMHO. The brim should follow the EFC. Sometimes you use EFC to create a psudo chamfer. Also its nice to keep some EFC on your default profile so then using brim you always have to compensate and turn it off.

Also, i don't think its realistic to think of EFC as perfectly compensating so that it will always perfectly meet the brim. And with EFC its always better to use a little more rather than a little less.

In the end Cura is right here. It will be better if its fixed in Orca. Most people probably don't realize that its just not working currently.

CCS86 commented 1 month ago

Beyond that, even with 0 EFC and 0 brim gap, there is still a gap:

image

PhilBaz commented 1 month ago

Just cross posting this here.....

https://github.com/bambulab/BambuStudio/issues/4420

Please guys, this bug is silly.

I see on the bambu side its been labelled and assigned. Maybe bring your issues to the Bambu side, it may get fixed there then make it to Orca down stream.