SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
6.18k stars 710 forks source link

Allow editing of acceleration for travel when klipper g-code flavor is selected #5188

Open Gozania opened 2 months ago

Gozania commented 2 months ago

Is there an existing issue for this feature request?

Is your feature request related to a problem?

It is asinine that travel acceleration cannot be edited. I understand this for marlin and such as a saftey precaution, however those of us who are on klipper should have total control of what OUR machine does. My ender 3 V2 can SAFELY do 5Kmms travel acceleration, yet the field is greyed out and capped at 500mms. I do not want to travel this slow...

Screenshot 2024-04-28 104013

Which printers will be beneficial to this feature?

Klipper, All

Describe the solution you'd like

If klipper is selected open up ALL motion fields for editing. Perhaps make a check box that needs to be ticked stating that the user understands the risk of editing the fields from default.

Describe alternatives you've considered

  1. Go back to PrusaSlicer until this is remedied along with other bugs I have reported.

Additional context

I really want to use your software due to its reputation and layout. However there are things I cannot overlook that orca slicer does that prusa does not. A 3rd party slicing software should NEVER limit people on what they can do with THEIR machine motion ability. C'mon Softfever, you can do better than this.

jamincollins commented 2 months ago
  1. Tone it down, jeez. There is no need (or call) for the tone in the above report.
  2. If you hover over the setting you'll find that it is disabled because it only applies to Marlin 2.

image

jamincollins commented 2 months ago

Here's the section of code that disables the field if you're using Klipper or legacy Marlin: https://github.com/SoftFever/OrcaSlicer/blob/main/src/slic3r/GUI/Tab.cpp#L4392-L4399

Gozania commented 2 months ago

I don't know what to do with the below link. I dont know how to code or program. Apologies for my frustration initially, but why is this a default when klipper is selected? Marlin, I can totally understand & would encourage the current configuration. While helping delvelop an S1 Plus profile for orca the developer I was helping also ran into an issue where he was unable to increase travel acceleration for that machine.

What needs to be done on my end to achieve my desired results?


From: Jamin Collins @.> Sent: Sunday, April 28, 2024 11:29 AM To: SoftFever/OrcaSlicer @.> Cc: Gozania @.>; Author @.> Subject: Re: [SoftFever/OrcaSlicer] Allow editing of acceleration for travel when klipper g-code flavor is selected (Issue #5188)

Here's the section of code that disables the field if you're using Klipper or legacy Marlin: https://github.com/SoftFever/OrcaSlicer/blob/main/src/slic3r/GUI/Tab.cpp#L4392-L4399

— Reply to this email directly, view it on GitHubhttps://github.com/SoftFever/OrcaSlicer/issues/5188#issuecomment-2081589504, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUAJIIB44LDBCSCGNYDNBF3Y7U5ZJAVCNFSM6AAAAABG5E5IK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGU4DSNJQGQ. You are receiving this because you authored the thread.Message ID: @.***>

Gozania commented 2 months ago

Never mind the instructions... I figured it out. Was able to achieve it by switching to marlin 2, making my adjustment, then switching back to klipper prior to saving.


From: Jamin Collins @.> Sent: Sunday, April 28, 2024 11:29 AM To: SoftFever/OrcaSlicer @.> Cc: Gozania @.>; Author @.> Subject: Re: [SoftFever/OrcaSlicer] Allow editing of acceleration for travel when klipper g-code flavor is selected (Issue #5188)

Here's the section of code that disables the field if you're using Klipper or legacy Marlin: https://github.com/SoftFever/OrcaSlicer/blob/main/src/slic3r/GUI/Tab.cpp#L4392-L4399

— Reply to this email directly, view it on GitHubhttps://github.com/SoftFever/OrcaSlicer/issues/5188#issuecomment-2081589504, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUAJIIB44LDBCSCGNYDNBF3Y7U5ZJAVCNFSM6AAAAABG5E5IK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGU4DSNJQGQ. You are receiving this because you authored the thread.Message ID: @.***>

jamincollins commented 2 months ago

Your change has no meaning. The setting is only used on a Marlin 2 system. This is not a bug.

Gozania commented 2 months ago

Ok, then how can I make it so that change does have meaning and will reflect while printing?


From: Jamin Collins @.> Sent: Sunday, April 28, 2024 4:37 PM To: SoftFever/OrcaSlicer @.> Cc: Gozania @.>; Author @.> Subject: Re: [SoftFever/OrcaSlicer] Allow editing of acceleration for travel when klipper g-code flavor is selected (Issue #5188)

Your change has no meaning. The setting is only used on a Marlin 2 system. This is not a bug.

— Reply to this email directly, view it on GitHubhttps://github.com/SoftFever/OrcaSlicer/issues/5188#issuecomment-2081699731, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AUAJIIEK6QYZCOPQISNBHX3Y7WB4RAVCNFSM6AAAAABG5E5IK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBRGY4TSNZTGE. You are receiving this because you authored the thread.Message ID: @.***>

mxfi commented 2 months ago

Klipper doesn't use max travel acceleration limits like in marlin. You can google how printer limits are set up and why, the information is readily available anywhere really.

What you have there is machine limits. Klipper sets this machine limit in the config file and doesn't accept changes from slicer, it has nothing to do with orcaslicer. It doesn't matter because as the popup menu explains, it's only used in Marlin 2 and is null in Klipper.

You can change travel acceleration in the printing profile "speed" tab. You can also set a max limit to any movement in your Klipper printer.cfg file. Doesn't matter if orca "maximum acceleration for printer" is set to 1 or set to 10000, if you put travel acceleration as 5k, it will move at 5k accelerations as long as it doesn't exceed your Klipper config limit, which is why it's greyed out.