Open yw4z opened 1 week ago
Please check my tickets for ui
@Eldenroot replied all on related tickets. let me know if there are more
@yw4z Hello, did you change the color of the writings on the license plate? thnx
@olcayoren yes i did it in previous color fixes PR but softfever requested to revert back that change
Would be great to transfer all unmerged changes and fixes -> and merge them¨. Thank you!
@yw4z Hello, did you change the color of the writings on the license plate? thnx
@SoftFever Hello, did it matter if the color remained orange? thnx
@Eldenroot we are goin with baby steps instead making major changes as we discussed with @SoftFever . dont worry they are on my list. but i will try these changes with less code changes this time
@olcayoren @SoftFever here is removed things from that commit. Softfever wanted to use a secondary colors on these screens because he pointed many things started to use same colors and that made things hard to pick. Decided to keeping orange color as secondary color will make things easier to pick then we didnt touched that areas
I'm ok with this logic. only yellow code on gcode viewer is a bit too much for me :)
yeah, it's less dull with accent color there ;)
this commit is part 2 for color fixes. part 1 was https://github.com/SoftFever/OrcaSlicer/pull/5239
TO-DO
• Recheck colors for disabled elements and row highlighting • Improve descriptions on state colors • Match titlebar icon hover color with new tab hover color
Dark mode support for sliced plates list > plate number
problem: text is hard to read on light theme
before vs after![Screenshot-20240615095443](https://github.com/SoftFever/OrcaSlicer/assets/28517890/b3ba021a-0477-4a41-9ee4-09a660c4b4e8)
Flushing volumes button active state background color
left over green color from bamboo studio
before vs after![Screenshot-20240615095007](https://github.com/SoftFever/OrcaSlicer/assets/28517890/2d04c343-06fc-473c-8693-229022b3b766)
Sidebar tab button background color on light theme
left over green color from bamboo studio. visible on bbl monitor & calibration tab and project tab
before vs after![Screenshot-20240615095630](https://github.com/SoftFever/OrcaSlicer/assets/28517890/0aeeb27b-0795-4c33-a0d4-1a359ccf614c)
Sidebar arrow not visible
Before![Screenshot-20240618185703](https://github.com/SoftFever/OrcaSlicer/assets/28517890/f48ce263-e612-4895-b853-7522ffe8db86)
After![Screenshot-20240618185732](https://github.com/SoftFever/OrcaSlicer/assets/28517890/3a9aa867-3fa6-4c48-ae73-6e73eb6d5716)
Home page
Selected tab color on light theme![Screenshot-20240615100836](https://github.com/SoftFever/OrcaSlicer/assets/28517890/8348f567-d508-4a67-b616-833649a4ec9e)
Button hover background on light theme![Screenshot-20240615100838](https://github.com/SoftFever/OrcaSlicer/assets/28517890/fa801973-5438-4040-8dd2-d02196774756)
Context menu item hover background on light theme![Screenshot-20240615101808](https://github.com/SoftFever/OrcaSlicer/assets/28517890/7bbcb81a-b3af-4e28-8e7f-af29b31c6bd1)
Darker background for thumbnail images on dark mode before makes you blind :)![Screenshot-20240618184512](https://github.com/SoftFever/OrcaSlicer/assets/28517890/844f0020-007d-407b-8006-37e56e7c1e73)
after![Screenshot-20240618184415](https://github.com/SoftFever/OrcaSlicer/assets/28517890/603f92e3-a608-4029-baf6-b9827065ee51)
Also matched colors for dark theme
Sidebar parameters group Title too bright on dark theme
Uses same color with tab text color![Screenshot-20240615110456](https://github.com/SoftFever/OrcaSlicer/assets/28517890/8fbeacfa-4fe8-47f4-aab7-cdffc3feb8e3)
Sidebar > Global > Search > Dropdown list > hovered item color
Sidebar > Global > Search > Match border color with other input/combo boxes
improves visibility of border![Screenshot-20240615115205](https://github.com/SoftFever/OrcaSlicer/assets/28517890/db4526be-4c6e-4342-a907-c56d196d228c)
Added descriptions to state colors
Still its mess but better than without any descriptions![Screenshot-20240615123956](https://github.com/SoftFever/OrcaSlicer/assets/28517890/42b7117f-ebce-4f44-908b-84b4cf40c365)
Paint gizmos > remove background of non active Tool / Brush buttons on dark mode
buttons has no background on light mode. and readability improves without background before
after
![Screenshot-20240615132550](https://github.com/SoftFever/OrcaSlicer/assets/28517890/c63bf7cc-67d0-4f62-b657-b5a351de6007)
Main tab bar > button hover color
Before
After
![orca-slicer_FMc4CVup7W](https://github.com/SoftFever/OrcaSlicer/assets/28517890/d3a030c6-9a57-4066-9108-d78b37e3810a)
Gizmos selected text background
before
after
![Screenshot-20240618140348](https://github.com/SoftFever/OrcaSlicer/assets/28517890/10a12ccf-efec-4532-8e52-01aaac1cb1d0)
Keyboard shortcuts window selected tab background color
before![Screenshot-20240618141354](https://github.com/SoftFever/OrcaSlicer/assets/28517890/0aa8678b-40fe-4700-96de-2be1cd6880c8)
after![Screenshot-20240618141345](https://github.com/SoftFever/OrcaSlicer/assets/28517890/d6aba60f-e4f5-483c-916d-8497b6f7b086)
About page > link color
before![Screenshot-20240618142829](https://github.com/SoftFever/OrcaSlicer/assets/28517890/56d83e45-abc9-4740-a567-82b63834f961)
after![Screenshot-20240618142846](https://github.com/SoftFever/OrcaSlicer/assets/28517890/a625a589-7be0-4cff-808c-74334b412c9a)
Project page > Add button
Project page > Return button text
before
after
![Screenshot-20240618155335](https://github.com/SoftFever/OrcaSlicer/assets/28517890/172cf535-af45-4a92-85e2-7f6248252a6c)
Match disabled text color of combo boxes with other input boxes while disabled state
before
after
![Screenshot-20240618165204](https://github.com/SoftFever/OrcaSlicer/assets/28517890/e1904320-812c-4bbe-af93-1379f813272a)
also this makes add printer window > combo boxes disabled text a bit more visible
![Screenshot-20240618173658](https://github.com/SoftFever/OrcaSlicer/assets/28517890/7bb39831-cc79-4160-acc4-052a7b2800f5)
Use better background color for disabled elements on dark mode
old color has a different tone compared to panel background. also not fits well imo old vs new![Screenshot-20240618165808](https://github.com/SoftFever/OrcaSlicer/assets/28517890/b2223b1e-e511-4f40-a173-2a3d5f28444f)
BBL > Monitor tab > Add printer text and icon not visible on dark theme
before
after
![Screenshot-20240618182453](https://github.com/SoftFever/OrcaSlicer/assets/28517890/6168f670-95a8-44b9-a3da-daedad7bdac6)
Better background color for row highlighting on dark theme
NOTE: color not changes while switching themes. its an existing bug used same color on sidebar titlebar background. it creates enough separation before
after
![Screenshot-20240620080416](https://github.com/SoftFever/OrcaSlicer/assets/28517890/7214dd53-522c-4700-950f-72d995cb907f)
Match style of gizmo combo boxes with regular combo box
target style
before
after
![Screenshot-20240620083237](https://github.com/SoftFever/OrcaSlicer/assets/28517890/44d02384-3613-4a0c-8d9d-f1267c153115)
Fixed broken color changes with latest merges
Selected tab underline color![Screenshot-20240618134237](https://github.com/SoftFever/OrcaSlicer/assets/28517890/f07240ca-6d20-4e63-91ce-d747d41ed9dd)