SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
5.89k stars 670 forks source link

Small area flow compensation not working - RC and Stable #5780

Closed adolfotregosa closed 4 days ago

adolfotregosa commented 1 week ago

Is there an existing issue for this problem?

OrcaSlicer Version

2.1-rc and Stable

Operating System (OS)

Linux

OS Version

manjaro

Additional system information

No response

Printer

voron 2.4

How to reproduce

small area flow compensation test.zip Rotate Z 270º

Actual results

image

2.1 - rc

Expected results

image

2.1 beta

Project file & Debug log uploads

small area flow compensation test.zip

Checklist of files to include

Anything else?

not working on RC

adolfotregosa commented 1 week ago

Not working on stable 2.1

Am I missing something ???

image

drewmoseley commented 1 week ago

Same behavior here. I tested on the 2.1.0 release on both Ubuntu (AppImage) and Mac (arm64/DMG).

mfish38 commented 6 days ago

Not working for me either. 2.1.0 release on Kubuntu AppImage

Screenshot taken with small area flow compensation on. image

mjonuschat commented 6 days ago

Looks like it was broken by https://github.com/SoftFever/OrcaSlicer/commit/9a4429f6037bb87001b78d9fe9f158bd5f1f4a61

AlexDF99 commented 6 days ago

I have the same problem, (2.1.0 and 2.0.0 final release) on Windows 11

TheSlashEffect commented 4 days ago

The issue persists on Linux as well. In its current state, m_config.small_area_infill_flow_compensation.value is not read as true when the feature is enabled, making the feature not activate. If I revert https://github.com/SoftFever/OrcaSlicer/commit/9a4429f6037bb87001b78d9fe9f158bd5f1f4a61 the feature works as expected again. Alternatively, if I move the definition of the config value small_area_infill_flow_compensation from PrintRegionConfig to PrintConfig, the feature works again. The value was moved to the region config due to this conversation: I tried making the feature work again in its current state but to no avail. I ported the feature with the same PrintConfig setup on PrusaSlicer and SuperSlicer and it works as expected in both cases.

SoftFever commented 4 days ago

Thanks, I will take a look

SoftFever commented 4 days ago

This should be fixed now.