Correct odd layer GUI description

SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)

https://discord.gg/P4VE9UY9gJ

GNU Affero General Public License v3.0

5.89k stars 670 forks source link

Correct odd layer GUI description #5793

Open vovodroid opened 1 week ago

vovodroid commented 1 week ago

Currently every second layer for "on odd layer" options is checked as layer_id % 2 == 1. Though from mathematics POV it's correct, but in GUI first layer is one and not zero, thus actually option is applied for even layers.

I guess this is SuperSlicer legacy, and this PR fix this confusing description in GUI.

kisslorand commented 1 week ago

Isn't the first layer numbered "0"?

vovodroid commented 1 week ago

In code yes, but in GUI first layer is "1".

vovodroid commented 1 week ago

vovodroid commented 5 days ago

Another option - call it "every other layer", like here