SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
6.08k stars 696 forks source link

3mf file overwritten even without confirmation #5829

Open manferlo81 opened 3 weeks ago

manferlo81 commented 3 weeks ago

Is there an existing issue for this problem?

OrcaSlicer Version

2.1.0

Operating System (OS)

Windows

OS Version

Windows 10

Additional system information

Core i5, 16Gb ram, NVIDIA GeForce GTX 1650

Printer

Ender 3

How to reproduce

You have a folder with 2 files (model.step & model.3mf)... create a new project..., add model.step file... when you hit "save", the file is saved as model.3mf overwriting the original model.3mf without even a "do you want to overwrite the file?" warning.

Actual results

3mf file overwritten

Expected results

At least warn about it

Project file & Debug log uploads

model.zip

files are inside the archive, but you dont need them for this issue. there are 2 file model.step (containing a cube) & model.3mf (containing a cylinder)

Checklist of files to include

Anything else?

I believe a distinction should be made about adding (or importing) a file and opening a project. When you have a new project and you add a model to it, the project sould not adopt the model filename, instead it sould keep its original filename "Untitled" or "New Project" or somethig like that. I understand sometimes it saves time to adopt the name but I believe it creates confusion. I think its better to let the user choose a filename when the project is being saved, and if the filename chosen already exists, OrcaSlicer should warn about it an let the user decide if overwrite or not.

discip commented 3 weeks ago

2nd that! This happened way to often! A confirmation popup would be sufficient.

Akaitatsu commented 2 weeks ago

Standard behavior for GUI applications would be to leave the filename as Untitled#.3mf until a Save As operation is performed. If the user clicks Save or hits Ctrl+S then it should do a Save As and prompt for a location and filename.