SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
6.68k stars 783 forks source link

Thumbnails not being displayed on qidi x-max 3 screen #5973

Open pmbroth opened 2 months ago

pmbroth commented 2 months ago

Is there an existing issue for this problem?

OrcaSlicer Version

2.1.1

Operating System (OS)

Windows

OS Version

windows

Additional system information

No response

Printer

Qidi X-max 3

How to reproduce

send job to printer, no thumbnail generated image

Actual results

black screen, no thumbnail is shown, goto Qidi users forums, users are all stating this with 2.1.1

Expected results

Thumbnail to be displayed

Project file & Debug log uploads

any stl will produce this outcome

settings below

image

Checklist of files to include

Anything else?

image

kiniad commented 2 months ago

I could confirm this for the Qidi X-Plus 3. Reason: The COLPIC section (gimage, simage) have to be at the end of the gcode, as it was before 2.1 final with the thumbnails revamp. See: https://github.com/SoftFever/OrcaSlicer/pull/5555

Viktor-N-snr commented 2 months ago

QIDI X-Plus 3, yes this problem is still there since previous versions. I tried all sorts of combinations of resolution, number of resolutions (for example 380x380/COLPIC only), other bitmap formats and so on. Nothing helped at all. A small thumbnail will appear in the file list. But not in the main window. Just the black square instead of the preview. With QIDI slicer it works corectly of course, ORCA doesn't. QIDI slicer settings are: 380x380/QIDI, 210x210/QIDI, 110x110/PNG. Well, ORCA doesn't know the QIDI type and uses COLPIC instead, but of course I immediately tried 380x380/COLPIC, 210x210/COLPIC, 110x110/PNG but alas — still the same, just black squere and not white circle or — required thumbnail… :-)))

cableguyed commented 2 months ago

Verified that if you save the gcode file, open with notepadd++ or similar and cut the ;gimage and ;simage sections, paste them at the very end, the thumbnails come right up when you use the device screen to upload the gcode file. I haven't had a chance to actually print a test file yet, but it looks promising. Should be a simple fix for Orca code.

Viktor-N-snr commented 2 months ago

Thanks for this interesting solution, but really there is no chance to edit each G-Code, when I am sending that directly to the printer. :-)

cableguyed commented 2 months ago

Hi, If you click on the down arrow next to the print tab and select save as gcode instead, then create the file, edit it to make it show the thumbnail, then go to the device tab and under jobs click on the plus sign and select upload, then browse to the edited gcode file and you will have the thumbnail on the printer screen when you select to print the file. This is just a temporary fix until the coders get around to qidi update on orca... I have multiple qidi printers and like to see what is on each at a glance. Regards, Ed

On Sun, Jul 14, 2024 at 9:26 AM Viktor-N-snr @.***> wrote:

Thanks for this interesting solution, but really there is no chance to edit each G-Code, when I am sending that directly to the printer. :-)

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/5973#issuecomment-2227386198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4WM7TALIB5B23UMSPC5WDZMKKBJAVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGM4DMMJZHA . You are receiving this because you commented.Message ID: @.***>

pmbroth commented 2 months ago

This is what I did, and it works on my qidi x-max 3, I moved the thumbnail section to the bottom of the configuration file. Move yellow section to the bottom, as I did in the json file attached. json file fdm_qidi_x3_common.json

cableguyed commented 2 months ago

That made no difference for my X-Max3.

On Mon, Jul 15, 2024 at 7:12 AM pmbroth @.***> wrote:

This is what I did, and it works on my qidi x-max 3, I moved the thumbnail section to the bottom of the configuration file. fdm_qidi_x3_common.json https://github.com/user-attachments/files/16234971/fdm_qidi_x3_common.json

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/5973#issuecomment-2228474861, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4WM7QSUIXSYNUSLT7J5L3ZMPDD7AVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRYGQ3TIOBWGE . You are receiving this because you commented.Message ID: @.***>

nicolalamacchia commented 1 month ago

Use this script in the post-processing setting: Global Settings -> Others -> [scroll to the bottom] -> Post-processing Scripts -> type the full path of the script you downloaded (make sure that the script is executable).

It worked for my X-Plus 3.

Thanks @kiniad. Looks like moving the whole thumbnail block works.

jimwhitelaw commented 1 month ago

I tried the solution posted by @pmbroth; it did not work on my X-Max 3.

cableguyed commented 1 month ago

Compiling the python script (with minor tweak to get the start point fixed) works great for both my X-Max3 and X-Smart 3. Thanks Nicola!

ovidakis commented 3 weeks ago

Compiling the python script (with minor tweak to get the start point fixed) works great for both my X-Max3 and X-Smart 3. Thanks Nicola!

Hi @cableguyed ! How did u do that? I'v copied that file to my: /home/mks/qidi_thumbnail.py and make it executable and after that I copied address to orcaslicer. Still not workig. Am I missing something?

1 image Thank you!

cableguyed commented 3 weeks ago

First, make a copy of the qidi_thumbnail.py just in case... I had to edit the qidi_thumbnail.py to change the " # Find the start and end of the thumbnail block" section to: for i, line in enumerate(lines): if re.match(r'; HEADER_BLOCK_END', line): thumbnail_start = i+1 if re.match(r'; external perimeters*', line): thumbnail_end = i-1 I haven't done any Python programming at all and any serious programming for years so I had to google some python methods to figure out that the program wants to look in the Python/scripts area for the compiled result. Below is my file path once I created the executable in Python. (And put your path in the post-processing scripts area in Orca.)

C:\Users\cable\AppData\Local\Programs\Python\Python312\Scripts\dist\qidi_thumbnail.exe;

I also had to change the image sizes for the different LCD screen sizes between my X-Max3 and my X-Smart3. X-Max3 = 380x380/COLPIC, 210x210/COLPIC, 110x110/PNG X-Smart3 = 210x210/COLPIC, 110x110/COLPIC, 110x110/PNG

Hope this helps! Regards, Ed

On Sun, Aug 25, 2024 at 5:24 AM ovidakis @.***> wrote:

Compiling the python script (with minor tweak to get the start point fixed) works great for both my X-Max3 and X-Smart 3. Thanks Nicola!

Hi @cableguyed https://github.com/cableguyed ! How did u do that? I'v copied that file to my: /home/mks/qidi_thumbnail.py and make it executable and after that I copied address to orcaslicer. Still not workig. Am I missing something?

1.JPG (view on web) https://github.com/user-attachments/assets/79f41d79-6122-4db7-8740-e458dd0897a9 image.png (view on web) https://github.com/user-attachments/assets/122c54ae-166b-458c-97de-e0af1647043d Thank you!

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/5973#issuecomment-2308788879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4WM7TZXZOOFQRBSFRLW5DZTG5F3AVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYG44DQOBXHE . You are receiving this because you were mentioned.Message ID: @.***>

ovidakis commented 3 weeks ago

Hi Ed, still not woking :( I looked to g-code file and I found at the end of the file that the post-processing script done the job. Probably xindi/display cant read correctly those lines. By the way, my printer (X-max3) is on latest firmware based on Debian 12 Bookworm. BR, ovi

cableguyed commented 3 weeks ago

I only update firmware from qidi direct, don't know if that makes a difference.

On Mon, Aug 26, 2024, 2:34 PM ovidakis @.***> wrote:

First, make a copy of the qidi_thumbnail.py just in case... I had to edit the qidi_thumbnail.py to change the " # Find the start and end of the thumbnail block" section to: for i, line in enumerate(lines): if re.match(r'; HEADER_BLOCK_END', line): thumbnail_start = i+1 if re.match(r'; external perimeters', line): thumbnail_end = i-1 I haven't done any Python programming at all and any serious programming for years so I had to google some python methods to figure out that the program wants to look in the Python/scripts area for the compiled result. Below is my file path once I created the executable in Python. (And put your path in the post-processing scripts area in Orca.) C:\Users\cable\AppData\Local\Programs\Python\Python312\Scripts\dist\qidi_thumbnail.exe; I also had to change the image sizes for the different LCD screen sizes between my X-Max3 and my X-Smart3. X-Max3 = 380x380/COLPIC, 210x210/COLPIC, 110x110/PNG X-Smart3 = 210x210/COLPIC, 110x110/COLPIC, 110x110/PNG Hope this helps! Regards, Ed … <#m2451421436868073245> On Sun, Aug 25, 2024 at 5:24 AM ovidakis @.> wrote: Compiling the python script (with minor tweak to get the start point fixed) works great for both my X-Max3 and X-Smart 3. Thanks Nicola! Hi @cableguyed https://github.com/cableguyed https://github.com/cableguyed https://github.com/cableguyed ! How did u do that? I'v copied that file to my: /home/mks/qidi_thumbnail.py and make it executable and after that I copied address to orcaslicer. Still not workig. Am I missing something? 1.JPG (view on web) https://github.com/user-attachments/assets/79f41d79-6122-4db7-8740-e458dd0897a9 https://github.com/user-attachments/assets/79f41d79-6122-4db7-8740-e458dd0897a9 image.png (view on web) https://github.com/user-attachments/assets/122c54ae-166b-458c-97de-e0af1647043d https://github.com/user-attachments/assets/122c54ae-166b-458c-97de-e0af1647043d Thank you! — Reply to this email directly, view it on GitHub <#5973 (comment) https://github.com/SoftFever/OrcaSlicer/issues/5973#issuecomment-2308788879>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4WM7TZXZOOFQRBSFRLW5DZTG5F3AVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYG44DQOBXHE https://github.com/notifications/unsubscribe-auth/AO4WM7TZXZOOFQRBSFRLW5DZTG5F3AVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBYG44DQOBXHE . You are receiving this because you were mentioned.Message ID: @.*>

Hi Ed, still not woking :( I looked to g-code file and I found at the end of the file that the post-processing script done the job. Probably xindi/display cant read correctly those lines. By the way, my printer (X-max3) is on latest firmware based on Debian 12 Bookworm.

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/5973#issuecomment-2311038823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AO4WM7Q75WMEI2FDVBVVYRLZTOGOPAVCNFSM6AAAAABKGGELHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJRGAZTQOBSGM . You are receiving this because you were mentioned.Message ID: @.***>

Brandon520x commented 6 days ago

I can confirm the thumbnails are not working on my X-Plus 3 with current QIDI firmware using 2.1.1. Very frustrating since this seems to have been committed in the latest build.

astrojolo commented 5 hours ago

Still not working on the X-Plus 3 and 2.2.0-beta version.