search

SoftFever / OrcaSlicer

G-code generator for 3D printers (Bambu, Prusa, Voron, VzBot, RatRig, Creality, etc.)
https://discord.gg/P4VE9UY9gJ
GNU Affero General Public License v3.0
6.66k stars 783 forks source link

Re-add Copy/Paste of Instance Groups #6570

Open morganvenable opened 2 weeks ago

morganvenable commented 2 weeks ago

Is there an existing issue for this feature request?

Is your feature request related to a problem?

https://github.com/SoftFever/OrcaSlicer/pull/6237 re-adds instancing support -- amazing!

But Copy/Paste of an Instance group today with 6237 only pastes the single master part, not the instance group

Prusaslicer's underlying behavior allows copy/pasting of instance groups to create a new instance group with a new master -- for people who print large numbers of parts with small variations, this is extremely useful to quickly reproduce identical arrays with different parts.

Which printers will be beneficial to this feature?

All

Describe the solution you'd like

When copy/pasting instances of an object, all instances should be pasted. A new master should be created for the pasted instances, as in Prusaslicer.

Describe alternatives you've considered

An option to paste instances linked to the ORIGINAL master would also be very useful for making complicated plates, but probably requires more work.

Additional context

No response

morganvenable commented 2 weeks ago

@vovodroid if you have any suggestions for where I should start poking on this, I'd be happy to take a crack at it.

vovodroid commented 4 days ago

Hi, can you please upload screenshots with desired functionality in Prusa? As I see if copy-paste instance group you get new object.

morganvenable commented 3 days ago

Yep, that's expected and useful -- I figured out what's going on that was confusing me -- in Prusa, when you copy/paste an instance group, it gets pasted with the relative positions maintained. In Orca, it gets pasted with all instances in the same location, which makes it useless for reproducing a given configuration of a large number of parts -- you still have to drag them all into position Is it possible to reproduce the "paste new instance group with original positions" functionality?

On Thu, Sep 12, 2024 at 1:12 AM Vovodroid @.***> wrote:

Hi, can you please upload screenshots with desired functionality in Prusa? As I see if copy-paste instance group you get new object.

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/6570#issuecomment-2345563162, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYPXFONYOELUSQIH5L3ZWFEIRAVCNFSM6AAAAABNEHEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGU3DGMJWGI . You are receiving this because you authored the thread.Message ID: @.***>

morganvenable commented 3 days ago

image Here's how it appears when I copy/paste two instance parts in Prusa -- they get offset diagonally from the original two, instead of going in the same place. In general these behaviors seem more consistent in Prusa -- when I Clone now on this dev version, Orca now puts all N copies in the exact same location instead of tiling them out. I wonder if that's related to putting the Instance code back in?

Okay yeah confirmed, in Bambu, the Clone function tiles correctly, but in Orca it doesn't do it: image

vovodroid commented 3 days ago

Bambu, the Clone function tiles correctly,

But there are no instances in Bambu? Do you copy-paste group of objects?

morganvenable commented 3 days ago

Yes. The use cases as follows: I have 100 identical parts which I need to arrange in a tight grid. I also have variants of these parts with the same general shape.

In prusa, I could create and arrange one instance group, copy/paste it onto several different plates, and replace the part in each instant group to get several different plates of several different parts, all in the same physical configuration.

On Thu, Sep 12, 2024, 9:41 AM Vovodroid @.***> wrote:

Bambu, the Clone function tiles correctly,

But there are no instances in Bambu? Do you copy-paste group of objects?

— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/issues/6570#issuecomment-2346774879, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYOYZSWHLZEEXXDXC63ZWG75HAVCNFSM6AAAAABNEHEIISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWG43TIOBXHE . You are receiving this because you authored the thread.Message ID: @.***>