search

SoftGeekRO / sgzenity

https://www.softgeek.ro
GNU General Public License v3.0
1 stars 0 forks source link

A few suggestions #1

Open Acumane opened 2 weeks ago

Acumane commented 2 weeks ago

Good work, this is the only* good GTK4 zenity wrapper for python.

A few things:

for progress_bar, callback should be ignored if pulse_mode is True. Otherwise, make callback optional.

And I'm nit-picking, but, naming conventions. Arguments needn't be named differently than their CLI counterparts (e.g. pulse_mode vs. pulsate) and methods called by the user can be more concise—like .run() instead of .run_progressbar()

SoulRaven commented 2 weeks ago

hello, thx for the feedback, any feedback is a good feedback.

I know, some problems are still in the code. Is WIP, so many changes will be from now on.

Currently i am working on a improved version for threading and how the tasks are done in Progress bar.

In my case the main implementation is for Nemo actions but i have also plans for future Gnome extensions.