search

SoftProjector / softprojector

Church media presentation software
http://softprojector.org/
GNU General Public License v3.0
46 stars 30 forks source link

Issue 52 media replays after ending and hiding screen #59

Closed jvkolyadich closed 3 years ago

jvkolyadich commented 3 years ago

Prevents video from restarting playback after hiding the screen when it ends, but the last frame still stays on the screen when the video ends if you build with some older versions of Qt. If you build with a newer version of Qt (5.13+), VideoOutput shows an empty frame after the video stops by default, so the problem gets fixed.

Video was restarting in ProjectorDisplayScreen::renderPassiveText() because backType was staying as B_VIDEO when calling updateScreen().

DmitriyS83 commented 3 years ago

Thank you for the fix, that worked for me with qt 5.15.2 build.

On Tue, Feb 9, 2021 at 12:47 PM James K notifications@github.com wrote:

Prevents video from restarting playback after hiding the screen when it ends, but the last frame still stays on the screen when the video ends if you build with some older versions of Qt. If you build with a newer version of Qt (5.13+), VideoOutput shows an empty frame after the video stops by default https://doc.qt.io/qt-5/qml-qtmultimedia-videooutput.html#flushMode-prop, so the problem gets fixed.

Video was restarting in ProjectorDisplayScreen::renderPassiveText() because backType was staying as B_VIDEO when calling updateScreen().

You can view, comment on, or merge this pull request online at:

https://github.com/SoftProjector/softprojector/pull/59 Commit Summary

  • fixed bug where media played after hiding screen
  • disabled stop showing button after video ends

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/SoftProjector/softprojector/pull/59, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFITEC6OGRZYPZTQNNKAG3S6FYK7ANCNFSM4XLNZOGQ .

vladozar commented 3 years ago

Thanks for the fix @jvkolyadich . I greatly appreciate it.