SoftProjector / softprojector

Church media presentation software
http://softprojector.org/
GNU General Public License v3.0
47 stars 30 forks source link

Text getting cut off #9

Closed MaxKam closed 6 years ago

MaxKam commented 6 years ago

When running the latest code, I'm seeing an issue where the secondary and tertiary Bible translations are getting cut off on some verses. Two examples below.

gen1-2 isaiah 66-11

As you can see the English verses don't finish. This happens no matter what translation is set as the secondary or tertiary versions. This issue only happens with some verses. I haven't been able to figure out specifically what causes this as there are much longer verses that appear just fine.

When I set the height manually for the "m_bdSets.ptRect" rectangle in imagegenerator.cpp, the verses all display correctly. Code examples below.

Original code:

377. if(haveSecondary && !m_verse.secondary_text.isEmpty())
378.    {
379.        painter->drawText(left,m_bdSets.stRect.top(),w,m_bdSets.ptRect.height(), tflags, m_verse.secondary_text);
380.    }

Manually setting height:

377. if(haveSecondary && !m_verse.secondary_text.isEmpty())
378.    {
379.        painter->drawText(left,m_bdSets.stRect.top(),w, 800, tflags, m_verse.secondary_text);
380.    }
vladozar commented 6 years ago

The issue has been fixed.

I'm not sure which source you were using, but if the latest, it had a simple copy-paste bug. It was fixed with this commit: https://github.com/SoftProjector/softprojector/pull/11/commits/194aeca715c31bd03b7c4e9d1bfb0a709e0752b5