Issue with IPv6 UDP Tunnel when rxe is built into kernel

[sbates130272]

Hi

Not sure if this is a major issue but I did notice than when I build my kernel with the RXE module built-in that it would fail to load at boot (on a VM) because it was failing to setup a IPv6 UDP tunnel. The git diff below resolved my issue for me.

If I build RXE as a module and load it after boot then I don't see an issue so I suspect this is an ordering issue and RXE is trying to setup the tunnel before IPv6 services are up and running?

Stephen

batesste@cgy1-donard:~/kernels/linux$ git diff diff --git a/drivers/infiniband/sw/rxe/rxe_net.c b/drivers/infiniband/sw/rxe/rxe_net.c index 0b8d2ea..d92d0b4 100644 --- a/drivers/infiniband/sw/rxe/rxe_net.c +++ b/drivers/infiniband/sw/rxe/rxe_net.c @@ -668,13 +668,13 @@ int rxe_net_init(void)

    spin_lock_init(&dev_list_lock);

• recv_sockets.sk6 = rxe_setup_udp_tunnel(&init_net, +/* recv_sockets.sk6 = rxe_setup_udp_tunnel(&init_net, htons(ROCE_V2_UDP_DPORT), true); if (IS_ERR(recv_sockets.sk6)) { recv_sockets.sk6 = NULL; pr_err("rxe: Failed to create IPv6 UDP tunnel\n"); return -1;
• }

•  }*/
  
  recv_sockets.sk4 = rxe_setup_udp_tunnel(&init_net,
                htons(ROCE_V2_UDP_DPORT), false);

[yonatanco]

thanks. we will reproduce this in our lab and solve this.

[yonatanco]

BTW we recently pushed several fixes to upstream kernel. i recommend you start using that. 4.8.0-rc5

[sbates130272]

Yeah I am using 4.8-rc5 ;-).

[sbates130272]

Guys

You can solve this particular issue using the following diff. However this exposes another issue with IPv6 on Soft-RoCE that I will report via an email to the linux-rdma mailing list.

diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c index 08e09d9..97bc74a 100644 --- a/drivers/infiniband/sw/rxe/rxe.c +++ b/drivers/infiniband/sw/rxe/rxe.c @@ -392,5 +392,5 @@ static void __exit rxe_module_exit(void) pr_info("rxe: unloaded\n"); }

-module_init(rxe_module_init); +late_initcall(rxe_module_init); module_exit(rxe_module_exit);