search

SoftVarE-Group / MibTeX

Minimalistic tool to manage your references with BibTeX
GNU Lesser General Public License v3.0
2 stars 1 forks source link

Implement sorting for all columns #5

Closed tthuem closed 8 years ago

tthuem commented 8 years ago

Currently, the sorting does not seem to work.

Kogoro commented 8 years ago

Solved with the new Single Export HTML in 88a06ef

tthuem commented 8 years ago

Still does not work for citations. Comparison appear to be string based.

tthuem commented 8 years ago

Again, does not work for citations. Seems to be string comparison again.

tthuem commented 8 years ago

If this works, we can release the first version.

Kogoro commented 8 years ago

Tested it again with Chrome, Firefox and Vivaldi. All browsers in the latest version and all sortings worked well including citations. In the tests, Firefox is only slower than the other two.

tthuem commented 8 years ago

zwischenablage-1

Still does not work for me.

Kogoro commented 8 years ago

Okay now I know the error. Through the brackets and the overall count the cells aren't numbers. So the solution should be to remove the complete numbers in the filter algorithm. It does not happen on my side because I did not have yearly citation count enabled.

tthuem commented 8 years ago

Oh, then it was my fault. I'm fine with removing the total number in brackets.

Kogoro commented 8 years ago

Can you test it again? In my test, it works with cells like "8 (16)".

tthuem commented 8 years ago

Still does not work...

tthuem commented 8 years ago

Please test with more than one digit for some entries. For one digit, everything works fine.

Kogoro commented 8 years ago

I have found out that I was working on the wrong function and that the return value for the sorting of numbers was wrong (must be -1 or 1). Also, the indices were wrong for the new layout. So now it should work on all columns.

tthuem commented 8 years ago

Sortings seems to be slower now, but it works. :)