search

SoftengPoliTo / SoftwareMetrics

2 stars 0 forks source link

Improved JS code style and logic #36

Closed WebReflection closed 3 years ago

WebReflection commented 3 years ago

This MR is a demonstration of what I meant in https://github.com/SoftengPoliTo/SoftwareMetrics/issues/35, and it could be improved as long as generally accepted in the source repository.

lu-zero commented 3 years ago

Thank you a lot!

@lucaardito shall we land it as update or you'd like to keep the improved code in a separate dir to make easier to compare it?

WebReflection commented 3 years ago

@lu-zero / @lucaardito I think the right repo is elsewhere, so I'll file an MR elsewhere accordingly 👍

lucaardito commented 3 years ago

I would keep both the implementations for further comparisons for now. Is it possible to place the improved code in a separate folder?

Thanks for your work

WebReflection commented 3 years ago

This PR is closed, I've filed a better one here: https://github.com/greensoftwarelab/Energy-Languages/pull/22

This code is JavaScript though, not sure how you'd call the new folder ... maybe JS ? ES2015? but let's see in the other MR what happens first.