search

Softeq / dotnet-guidelines

A set of coding guidelines for C#, design principles, and layout rules.
Other
13 stars 1 forks source link

R# schema #8

Closed andrei-anfilets closed 4 years ago

oleg-zaitsev commented 4 years ago

@eabliazimov , @smolyakoff , @andrei-anfilets , shouldn't we added an indicator that a rule has R# support? It could be an icon as we previously used in Confluence?

eabliazimov commented 4 years ago

@eabliazimov , @smolyakoff , @andrei-anfilets , shouldn't we added an indicator that a rule has R# support? It could be an icon as we previously used in Confluence?

Yep, that gone out of my mind. Nice catch Oleg! @andrei-anfilets could you please make an adjustments?

andrei-anfilets commented 4 years ago

Yep, that gone out of my mind. Nice catch Oleg! @andrei-anfilets could you please make an adjustments?

Done, could you please review it?

oleg-zaitsev commented 4 years ago

Yep, that gone out of my mind. Nice catch Oleg! @andrei-anfilets could you please make an adjustments?

I also recommend adding tips to the images describing how exactly the rule is covered by R#. I thinks we must do this at least for partially covered rules.

Tips can be added this way: 

<img src="source of image" title="this will be displayed as a tooltip"/>
oleg-zaitsev commented 4 years ago

Please change line break up in C# formatting according to the screenshot below image

oleg-zaitsev commented 4 years ago

Please ensure that file layout and rule-1803 are syncronized.

oleg-zaitsev commented 4 years ago

Yep, that gone out of my mind. Nice catch Oleg! @andrei-anfilets could you please make an adjustments?

I also recommend adding tips to the images describing how exactly the rule is covered by R#. I thinks we must do this at least for partially covered rules.

Tips can be added this way:

<img src="source of image" title="this will be displayed as a tooltip"/>

I have created a separate issue for that, so let's postpone the comment for now.