SB does not initialize correctly since R17+ ?!

[spastik303]

Hello,

I haven't been able to find anything relating to this issue so I figured I'd come here to report it.

My Smartbuff will not detect that buffs are required unless I do a "reset all" every session. (I have to do this every time I log on to a character for it to start working again) No splash screen, no manual activation of the button; it's as if the mod stays dormant until I do said "reset all".

I've tried clean UI / deleting every WTF / Addon / Saved Variable folder and doing ultra clean install, etc... It does work in r16, but r17 and above does not.

Any insight would be appreciated, love the mod. (Running R16 for now to get around the issue)

TY

[speedwaystar]

that's extremely bizarre. i can't reproduce that behaviour at all. can you tell me your class, level and what language the client is set to?

[spastik303]

All classes, all specs, all levels, English - NA Region

Hello,

OK, after a bunch of trial and error testing I think I've narrowed down how the mod "breaks" for me.

If I load into a character while the "Switch template" checkbox is UNCHECKED, then the mod does not appear to check if any buffs are required. If I then open /SB Menu and check said box... it kicks in and starts working again.

Hope this helps narrow it down. Thank you!

(I would evidently disable this every time, as I normally want a single buffing profile, which doesn't change based on group / activity type.)

[ynazar1]

This has been fixed in the code, though I'm not sure if that's been pushed to curse. @speedwaystar 's code is in the main branch. Grab the code zip and replace the files in your addon folder for now. Also see #14

[spastik303]

Super, thank you! (Sorry for not making intially making the link to the prior reported issue!)

[speedwaystar]

just pinging @Softrix to double check that the latest build is live on Curse: refer discussion above.

[Softrix]

Last version reaching curse was r19 which included the GetSpellBookItemName change among other changes, this was the last pull request I have received since then, uploaded Feb 3, 2023 so if there has been any new pull requests since then I have sadly not got them again from github (just checked again, nothing pending).

[speedwaystar]

you're basically up to date then. my subsequent commits aren't relevant to the issue at hand. https://github.com/Softrix/SmartBuff-Retail/compare/main...speedwaystar:SmartBuff-Retail:main i suppose they might as well be pushed though. i'll create a request.

[Softrix]

Request merged and pushed to Curse in r20

[Softrix]

just to make sure :)

[spastik303]

Amazing; much appreciated! 👏🐱‍🏍

(Just got R20 from Curse, confirming issue is resolved)

[Softrix]

Perfect, closing.

[ynazar1]

Thanks all. Looking at dates, r19 was released to curse on Feb 3rd and #14 got fixed on Feb 4th... We were beta-testing in Discord and everything worked but forgot to push it up to curse after confirmed fixed. Glad it's all resolved now.