Modify Invalid Field Names or Types

[hcn1519]

In the process of defining the OpenSCENARIO Protocol Buffer, there are issues where incorrect field names or types may be specified. There are two main reasons for this.

1. Generation Issues

Errors may occur during the manual work and the generation of protobuf using ChatGPT, leading to inaccuracies in field names or types. For example, field name should be camel case format but they are defined in snake case format.

• [x] Property
• [x] LanePosition: lane_id, road_id
• [x] SpeedCondition has undefined fields direction and condition.

  
  // Message for SpeedCondition
  message SpeedCondition {
  optional DirectionalDimension direction = 1;  // 0..1

• required EntityCondition condition = 2; // 1..1 required Rule rule = 3; // 1..1 required double value = 4; // 1..1 }

• [x] StantStillCondition has undefined fields condition.

  
  // Message for StandStillCondition
  message StandStillCondition {
  required double duration = 1;  // 1..1

• required EntityCondition condition = 2; // 1..1 }

• [x] ReachPositionCondition is deprecated in OpenSCENARIO v1.2 ,but it is still in used.
• [x] RelativeDistanceCondition should be updated by following specification.

- (Unsupported)
message RelativeDistanceCondition {
+    required string entityRef = 1; // 1..1
+    required RelativeDistanceType relativeDistanceType = 2;
+    required double value = 3;
+    required double freespace = 4;
+    required Rule rule = 5;
}

• [x] ParameterDeclaration

  
  message ParameterDeclaration {
  required string name = 1;                  // 1..1
  required ParameterType parameterType = 2; // 1..1
  required string value = 3;                 // 1..1

• repeated ValueConstraintGroup constraint_groups = 4; // 0..*

• repeated ValueConstraintGroup constraintGroups = 4; // 0..* }

• [x] TrafficSignalControllerCondition

  
  // Message for TrafficSignalControllerCondition
  message TrafficSignalControllerCondition {
  required string phase = 1;  // 1..1

• required TrafficSignalController trafficSignalControllerRef = 2; // 1..1

• required string trafficSignalControllerRef = 2; // 1..1

• repeated Phase phaseRef = 3; // 0..* }

• [x] EntityAction

  
  message EntityAction {

• required EntityRef entityRef = 1; // 1..1

• required string entityRef = 1; // 1..1 optional AddEntityAction addEntityAction = 2; // 0..1 optional DeleteEntityAction deleteEntityAction = 3; // 0..1 }

• [x] AddEntityAction

  
  message AddEntityAction {
  required Position position = 1;      // 1..1

• required EntityAction entityAction = 2; // 1..1 }

• [x] TrafficSignalControllerAction

  
  message TrafficSignalControllerAction {
  required string phase = 1; 
  required TrafficSignalController trafficSignalControllerRef = 2;

• required Phase phaseRef = 3; }

• [x] TrafficSignalControllerAction

  
  message TrafficSignalControllerAction {
  required string phase = 1; 

• required TrafficSignalController trafficSignalControllerRef = 2;

• required string trafficSignalControllerRef = 2; }

• [x] FollowTrajectoryAction

• [x] ScenarioDefinition

message ScenarioDefinition {
-    repeated ParameterDeclaration parameterDeclarations = 1;  // 0..*
+    optional ParameterDeclarations parameterDeclarations = 1;  // 0..*
    required CatalogLocations catalogLocations = 2;           // 1..1
    required RoadNetwork roadNetwork = 3;                     // 1..1
    required Entities entities = 4;                           // 1..1
    required Storyboard storyboard = 5;                       // 1..1
}

2. Specification Issues

If the OpenSCENARIO specification does not adhere to a unified definition, modifications to field names may be necessary.

• [x] Type of Private's entityRef is defined in Entity in Table, but XSD 1.0 Representation defined its type to String.
• [x] #25