search

Software-Developer-Academy / mentor-match

Mentor Matching website
12 stars 16 forks source link

Allow a user to view the password they're typing when on a non-critical authentication form. #54

Open Ragudos opened 4 months ago

Ragudos commented 4 months ago

In signin and signup forms, it will be nice to view the passwords like how Google or other sites do it.

Though, for forms that are critical (retrieving sensitive data for example), the password being type should not be allowed to be visible.

coltonehrman commented 4 months ago

@jeevikasirwani are you still working on this one? I see your open PR but no response to comments made on it yet.

jeevikasirwani commented 4 months ago

@jeevikasirwani are you still working on this one? I see your open PR but no response to comments made on it yet.

Yes ..I did read your comments I think I made commit 4 days ago , that is all I could contribute as per my understanding

coltonehrman commented 4 months ago

@jeevikasirwani Let me know if you have any questions on how to resolve the comments in your PR. Still some outstanding items to take care of