Software-Engineering-Jagiellonian / django-celery-frege

Tool for measuring open source code repositories
GNU General Public License v3.0
6 stars 35 forks source link

feat: Generify lizard based analyzers #61

Closed FilipSzm closed 1 year ago

FilipSzm commented 1 year ago
FilipSzm commented 1 year ago

Hi @ConsoleRunner , I created a "generic" directory in the tests folder to store tests for all lizard-based language analyzers. With that, I also moved mock files in there. It's a little difficult to see the path change in github, but there is one from tests/... to tests/generic/... If you think there is no reason to create this subdirectory in tests, I will gladly delete it :)

ConsoleRunner commented 1 year ago

Hi @ConsoleRunner , I created a "generic" directory in the tests folder to store tests for all lizard-based language analyzers. With that, I also moved mock files in there. It's a little difficult to see the path change in github, but there is one from tests/... to tests/generic/... If you think there is no reason to create this subdirectory in tests, I will gladly delete it :)

Ah, I missed that, thx for the quick response - no need for reverting it, but please clarify what would classify as a non-generic test in that context (for future devs to better utilize current test-related file structure).

Edit: added motivation behind my question

FilipSzm commented 1 year ago

I named all analyzers made using the lizard library generic. I think this name is adequate because I doubt there will be another big library used for analyzers, and I think it's a better naming convention than something related to the lizard name. So in short, generic = lizard based, and anything else is non-generic

ConsoleRunner commented 1 year ago

I named all analyzers made using the lizard library generic. I think this name is adequate because I doubt there will be another big library used for analyzers, and I think it's a better naming convention than something related to the lizard name. So in short, generic = lizard based

Alright, thanks for clarification 👍