mathieucarbou
commented
7 months ago @MarcFriedhoff : the current helm charts in this PR pass our smoke tests without security enabled.
They fail when security is enabled.
The reason is that you have changed the service names and statefulset names by prepending {{ include "common.names.fullname" . }}.
This has the consequence of changing the hostnames of the servers, their names also, and pod names, and thus how security works.
We initially didn't want for the user to be able to change the internal k8s assigned named for services and statefulset. The reason is that changing that changes all the security config of the user, and also the tc config file.
The problem comes when a user needs to replicate for example a tc cluster somewhere else. He needs to be able to keep the same config files and data and move and without any server name, pod name change or service name change.
The change you did will also break the compatibility with an existing deployment in terms of tc-config files and security config files.
So I will rollback your changes.
If you can show us a really good reason to do that, which can be a blocker regarding k8s deployment for example, then tell us.
But if it is just for convention purposes or to make things beautiful, then, this change is not acceptable.
I will add a commit on top of this one to isolate this rollback from the rest.
MarcFriedhoff
This PR contains:
As requested, can you please give Haque and me access to this repo in RW so that we can correctly and efficiently maintain our Helm Charts. We need to:
Thanks.