SoftwareBrothers / adminjs-dev

Development environment for AdminJS
MIT License
48 stars 26 forks source link

Admin bro #19

Closed Chukstart closed 2 years ago

Chukstart commented 4 years ago

Courtesy of Grammarly and Spelling Checker come on I'm not that good at English I had to cheat plus I learnt of this new awesome tool Search Editor:Apply Changes

wojtek-krysiak commented 4 years ago

sorry for the late response. The files you updated are the output sources. The one needed to be updated are specified in jsdoc.json. Take a look how to build the documentation btw to see how that works. BUT.... :) after seeing your PR I found this: https://marketplace.visualstudio.com/items?itemName=znck.grammarly !!!

it works with .md files but not with .js/.ts comments. When I will have some time I will fork it and update to handle jsdoc comments.

Chukstart commented 4 years ago

It was my first pull request I knew I would do something wrong that's one saturday I won't get back though I did learn now three things so far always ask for clarification,the three new vs code tools and I don't know anything about jsdoc.json files

On Wed, Sep 9, 2020 at 11:37 AM Wojciech Krysiak notifications@github.com wrote:

sorry for the late response. The files you updated are the output sources. The one needed to be updated are specified in jsdoc.json. Take a look how to build the documentation btw to see how that works. BUT.... :) after seeing your PR I found this: https://marketplace.visualstudio.com/items?itemName=znck.grammarly !!!

it works with .md files but not with .js/.ts comments. When I will have some time I will fork it and update to handle jsdoc comments.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SoftwareBrothers/admin-bro-dev/pull/19#issuecomment-689416823, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJGL42RFT6NEGHP5NML346DSE45DHANCNFSM4QPHY53Q .

ariansobczak-rst commented 2 years ago

Misspell is already fixed in the new documentation. Tutorials need to be rewritten anymore.