search

SoftwareBrothers / adminjs-sequelizejs

Sequelizejs adapter for AdminBro
MIT License
27 stars 34 forks source link

Fix string filter problem with multiple fields #61

Closed ElvisYang closed 3 years ago

ElvisYang commented 3 years ago

Fix the problem for: When applying more than one string field for filtering, only the first field works, the others just override by the first one.

ElvisYang commented 3 years ago

@wojtek-krysiak could you review this PR?

dziraf commented 3 years ago

Looks good, can you fix the test (the missing comma) and I will merge the PR?

ElvisYang commented 3 years ago

@dziraf Thanks, I have fixed the test. so one more question, when this is merged in, when we can get this publish?

Bkahler commented 3 years ago

I am facing the same issue, would love to see this merged and available to use soon

dziraf commented 3 years ago

Could you also rebase your branch to this repo's master? I've pushed some changes to the same file recently and it looks odd to me that it doesn't show any conflicts...

Once all is good, I'll merge and this will be deployed soon after.

ElvisYang commented 3 years ago

@dziraf Done, hope this looks good now

ElvisYang commented 3 years ago

and do i need to change version number for publishing? https://github.com/SoftwareBrothers/admin-bro-sequelizejs/blob/master/package.json#L3

dziraf commented 3 years ago

Thanks! Merging it now.

and do i need to change version number for publishing?

Nope, we use semantic-release library to automatically manage versioning.

github-actions[bot] commented 3 years ago

:tada: This PR is included in version 1.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

ElvisYang commented 3 years ago

Thanks @dziraf