SoftwareBrothers / adminjs-typeorm

TypeORM adapter for AdminJS
MIT License
24 stars 32 forks source link

Doesn't work with new version of TypeORM #41

Closed AshotN closed 2 years ago

AshotN commented 2 years ago

The adapter does not seem to work with new versions of TypeORM, simple things like selecting a row throw an error due to TypeORM's breaking changes.

jamiecounsell commented 2 years ago

The latest version of TypeOrm (0.3.X) is significantly different so this will likely be a lot of work to update. This project's package.json does correctly indicate its peer dependency requirement:

"devDependencies": {
  "typeorm": "~0.2.45",
}

I understand this will take some time for the contributors and community to update (I will also evaluate the effort myself) but it would be fantastic to at least get the maintainers to clarify if they intend to provide support for this version and (if possible) any ETA for that work.

I am starting out some new work and AdminJS may be a tool we evaluate but we are using TypeOrm 0.3.X so this would be a dependency.

In the meantime, when installing, you will see the error (posting here to attract search results):

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: your-project@1.0.0
npm ERR! Found: typeorm@0.3.6
npm ERR! node_modules/typeorm
npm ERR!   typeorm@"^0.3.5" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typeorm@"~0.2.45" from @adminjs/typeorm@2.0.4
npm ERR! node_modules/@adminjs/typeorm
npm ERR!   @adminjs/typeorm@"*" from the root project
npm ERR! 
github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: