SoftwareBrothers / adminjs

AdminJS is an admin panel for apps written in node.js
https://adminjs.co
MIT License
8.23k stars 661 forks source link

Google chrome autocomplete #1347

Open damian-balas opened 1 year ago

damian-balas commented 1 year ago

Describe the bug Hi, I've noticed that AdminJS doesn't get the values updated by chrome autocomplete. For example address city would be blank after sending the create request. (only street would be filled out)

Installed libraries and their versions

To Reproduce Steps to reproduce the behavior:

  1. Create something
  2. Use the autocomplete feature
  3. Click save button

Expected behavior AdminJS should update it's internal state when input value changes

Screenshots image image


I have one more question/bug to report. I didn't want to create a separate issue as this could not be a bug :)

Throwing ValidationError has different behavior in After action then in Before action. In the After action it doesn't use the actionErrorHandler

 new: {
        before: [doesWorkHere],
        after: [doesNotWorkHere],
}
 throw new ValidationError({
      address: {
        message:
          'Try again',
      },
    });

The response in After looks like this:

{
    "statusCode": 400,
    "message": "Resource cannot be stored because of validation errors"
}

Let me please know if I should create a separate issue for this :)

damian-balas commented 1 year ago

Any progress? Thanks! :)